Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3408]Use surveyGroupId when searching. #3420

Merged
merged 1 commit into from
Feb 17, 2020
Merged

[#3408]Use surveyGroupId when searching. #3420

merged 1 commit into from
Feb 17, 2020

Conversation

stellanl
Copy link
Contributor

Before the PR (what is the issue or what needed to be done)

surveyGroupId param was ignored when search param weas present.

The solution

Pass it to the lookup method.

Screenshots (if appropriate)

Reviewer Checklist

  • Added an explanation about the work done
  • Connected the PR and the issue on Zenhub
  • Added a test plan to the issue
  • Updated the copyright header (when relevant)
  • Formatted the code
  • Added a documentation (if relevant)
  • Added some unit tests (if relevant)

@stellanl stellanl requested a review from iperdomo February 17, 2020 11:04
@iperdomo iperdomo merged commit 11c7627 into release/1.11 Feb 17, 2020
@iperdomo iperdomo deleted the issue/3408-only-one-since-in-search branch February 17, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iperdomo iperdomo iperdomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellanl @iperdomo