MINOR - Donations email issues

[rumca]

I noticed a few minor issues with thank you emails whilst testing:

• A new thank you email is generated every time a invoice is updated in the RSR admin - even though nothing may change in the thank you.
• Weird formatting on the thank you email whereby the values are below their respective labels:

[adriancollier]

First is a known issue/feature - but I think this should be changed.

Second is new to me, but agree that this looks very messy and should be fixed.

[adriancollier]

We need to check the template here: https://github.com/akvo/akvo-rsr/blob/develop/akvo/templates/rsr/project/donate/donation_confirmation_email.html and fix the styling issues.

[adriancollier]

I have just resent one by saving a pre-existing donation and I see nothing wrong...

[adriancollier]

Ah - the problem seems to occur when viewing the email in Gmail. The template in Apple mail renders correctly:

But exactly the same mail in Gmail (Firefox browser) doesn't:

[rumca]

@adriancollier apologies - I should have included that in the original issue (I was using gmail when I took the screenshot).

[adriancollier]

@loicsans did you find anything that might explain this?

The Template is here by the way: https://github.com/akvo/akvo-rsr/blob/develop/akvo/templates/rsr/project/donate/donation_confirmation_email.html

[loicsans]

It's actually a known issue with Gmail. Some tag level inlined CSS are ignored. A safest way would be to use table to layout the email properly instead of floating divs.

[adriancollier]

@loicsans is this much work? Would you be able to do this? 😉

[loicsans]

Shoot it my way ;)

[adriancollier]

Well this issue is now assigned to you :) just needs a feature/460-donationemail branch to make the changes in

[loicsans]

@zzgvh How could I test this out on my local machine?

[adriancollier]

@zzgvh If all code is merged to develop can you please close this issue?

[adriancollier]

I see all code now in develop, so closing this issue.