Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#460] Removed floating Div / Replaced by a table #495

Merged
merged 1 commit into from
Apr 7, 2014

Conversation

loicsans
Copy link
Contributor

@loicsans loicsans commented Apr 4, 2014

@zzgvh Can you check if the table layout fix the gmail bug?

@zzgvh
Copy link
Contributor

zzgvh commented Apr 7, 2014

Code reviewed, merging for testing on test 😉

zzgvh added a commit that referenced this pull request Apr 7, 2014
[#460] Removed floating Div / Replaced by a table
@zzgvh zzgvh merged commit f2af4ef into develop Apr 7, 2014
@zzgvh zzgvh deleted the feature/460-donationemail- branch April 7, 2014 08:42
@zzgvh
Copy link
Contributor

zzgvh commented Apr 7, 2014

Looks good in Gmail!

@loicsans
Copy link
Contributor Author

loicsans commented Apr 7, 2014

Do you have any screentshot?

@zzgvh
Copy link
Contributor

zzgvh commented Apr 7, 2014

Yep:

Screen shot of gmail donation thanks

@loicsans
Copy link
Contributor Author

loicsans commented Apr 7, 2014

Much better, I though need to add some padding on the right column, and the title "A summary of your contribution" needs to get left aligned.

@zzgvh
Copy link
Contributor

zzgvh commented Apr 7, 2014

I think I can manage that.

zzgvh added a commit that referenced this pull request Apr 7, 2014
As per Loïc's instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants