Trigger CI on PRs too #250
Conversation
An omission from the original ci.yml can prevent some pull requests from triggering CI.
|
I love this because it is recursive in a way. It adds a feature to build on PRs and it demonstrates itself. |
|
This will be accepted, now it's just my curiosity kicking in. In what case does pull request trigger on it's own? |
|
I observed an issue in the Roosevelt projects where some PRs would get the CI triggered against them automatically (like the Renovate ones) and some would not (most user-generated ones). After researching the docs I discovered this config change is needed to guarantee that every PR will trigger the CI. I'm not sure why some PRs already triggered it and others didn't exactly, but this seemed to fix it on the Roosevelt repos, so I figured I'd propagate the change here too just to be safe. |
|
The PRs that would trigger are ones from branches of the main project. The ones that would not trigger were from forks. |
------------------ * Changed `passphrase` option from `https.p12.passphrase` to `https.passphrase` so it can be used for certAndKey configurations as well - See: #251 * Tweaked CI configuration file so GitHub Actions CI will also run on pull requests - See: #250 * Updated nyc from 15.0.1 to 15.1.0 - See: #249 * Fix the repository URL in package.json - See: #252
------------------ * Changed `passphrase` option from `https.p12.passphrase` to `https.passphrase` so it can be used for certAndKey configurations as well - See: #251 * Tweaked CI configuration file so GitHub Actions CI will also run on pull requests - See: #250 * Updated nyc from 15.0.1 to 15.1.0 - See: #249 * Fix the repository URL in package.json - See: #252
An omission from the original ci.yml can prevent some pull requests from triggering CI.