Move https.p12.passphrase to https.passphrase #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Key configurations
|
Nice catch on this! Appreciate the PR. |
alallier
added a commit
that referenced
this pull request
Jun 10, 2020
------------------ * Changed `passphrase` option from `https.p12.passphrase` to `https.passphrase` so it can be used for certAndKey configurations as well - See: #251 * Tweaked CI configuration file so GitHub Actions CI will also run on pull requests - See: #250 * Updated nyc from 15.0.1 to 15.1.0 - See: #249 * Fix the repository URL in package.json - See: #252
Merged
alallier
added a commit
that referenced
this pull request
Jun 10, 2020
------------------ * Changed `passphrase` option from `https.p12.passphrase` to `https.passphrase` so it can be used for certAndKey configurations as well - See: #251 * Tweaked CI configuration file so GitHub Actions CI will also run on pull requests - See: #250 * Updated nyc from 15.0.1 to 15.1.0 - See: #249 * Fix the repository URL in package.json - See: #252
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The passphrase option for HTTPS servers can be used for cert+key configs as well as the p12/pfx config. This small change generalizes the passphrase param so it's not locked exclusively to p12 configs. This will allow reload to support more varieties of HTTPS configurations.