This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
forked from bigbluebutton/docker
-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "use env file in greenlight database"
This reverts commit e056e52.
- Loading branch information
1 parent
5fbefe5
commit 27dde44
Showing
2 changed files
with
6 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27dde44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a particular reason why you reverted the use of .env for the postgres credentials?
Outside connections to the db should not be possible, thats why its probably ok to use a weak password, but it also wouldn't hurt to have a secure password?
27dde44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yksflip
this was reverted, because it was a change not related to the merge request: #16 (comment)
generally I also think, that additional security is always good and in this case, it doesn't really hurt :)