Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Add recording feature #16

Merged
merged 29 commits into from
Sep 6, 2020
Merged

Add recording feature #16

merged 29 commits into from
Sep 6, 2020

Conversation

artemtech
Copy link

@artemtech artemtech commented Jun 18, 2020

Video recording is working, but not for audio yet :(

edit by @alangecker:
closes #4

@alangecker
Copy link
Owner

seems like quite some effort so far. thanks a lot!

a goal of this project was to avoid having a monolithic container but rather using dockers benefits and splitting the functionality in different containers, which are easier maintainable and more stable.

The path of reaching this goal was to start with the "official" approach (bigbluebutton/docker) which I called core and isolating step by step parts into there own containers. The idea was that at the end™ the core container is gone, because all its components are extracted and clearly separated.
This MR now, for the first time, adds components again to core which for me personally doesn't feel reasonable since it would mean a step away from this design concept.

Also there are quite a lot of people who are using BBB intentionally without the recording functionality because of privacy concerns (bigbluebutton/bigbluebutton#9202). A separate recording container would also provide an easy way for running it optionally.

Can you imagine moving the feature into an own container?

  • The easy way probably would be to simple duplicate core/Dockerfile, but removing all the core things (like bbb-web, red5, etc.)

During the next two weeks I will be quite busy, but after that I can also help with that task if you don't feel motivated! ;)

@artemtech
Copy link
Author

oh ok, i'll give it a try to separate recording container,

@alangecker
Copy link
Owner

alangecker commented Jul 22, 2020

I've managed to get audio recording! :)

currently freeswitch's mod_opusfile in the official freeswitch debian repository can't create a file. there is an open pull request fixing it, but not merged yet: signalwire/freeswitch#719

I now replaced it with the binary from the official bigbluebutton repo and added the libopusenc0 dependency.

additionally:

  • created volumes so core has access to freeswitch and kurento's recording files
  • fixed etherpad url, so the script is able to collect the pad content (there was an error in the logs)

I did already some work with separating the recording stuff into its own container, I will hopefully finish that in the next days ;)

@alangecker
Copy link
Owner

alangecker commented Jul 27, 2020

so, now in a working state with an own container. feel free to review it! :)

open tasks

  • rebase to current develop
  • conditional settings based on ENABLE_RECORDING in bigbluebutton.properties and html/settings.yml
  • improving size of recordings-process container (rather difficult to achieve. maybe a step for another time!)
  • review!

@alangecker alangecker mentioned this pull request Jul 28, 2020
4 tasks
@alangecker alangecker changed the base branch from v2.2.x to develop July 28, 2020 09:17
@alangecker
Copy link
Owner

so, everything is done from my perspective.
Would be anyone up for doing a review? maybe @artemtech? :)

@alangecker alangecker closed this Aug 12, 2020
@alangecker
Copy link
Owner

I'm not really sure how/why I apparently closed this PR?^^

@alangecker alangecker reopened this Aug 29, 2020
@congthang1
Copy link

Is this working? Lol

@artemtech
Copy link
Author

i have tested it and works well in my setup.

@staukini
Copy link

staukini commented Sep 4, 2020

Nice work @artemtech and @alangecker !

Thanks a lot - can't wait for a merge to the main branch.

@senatoregiorgio
Copy link

Thank you very much for implementing this feature! 🙂

When are you going to merge this pull request to the master branch? 🚀

@alangecker alangecker mentioned this pull request Sep 6, 2020
4 tasks
@alangecker alangecker changed the base branch from develop to v2.2.x September 6, 2020 10:08
@alangecker alangecker changed the base branch from v2.2.x to develop September 6, 2020 10:08
@alangecker
Copy link
Owner

It is finally so far! 🎉

(will be included in the main v2.2.x branch with the Release v2.2.23-1)

@alangecker alangecker merged commit e6ff3c7 into alangecker:develop Sep 6, 2020
@alangecker
Copy link
Owner

argh @artemtech
i've just seen (after merging) that you later added some changes which aren't related to that recording feature.
I'll revert them again for the Release v2.2.23-1, but feel free to open new Pull Requests for them! :)

alangecker referenced this pull request Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants