feat: add entity id nonce logic #1209

howydev · 2024-12-12T20:54:12Z

PR-Codex overview

This PR primarily focuses on updating the versions of various packages and components in the project, along with adding a new React Native example application. It includes improvements to the Android and iOS configurations, as well as updates to the smart contracts and utilities.

Detailed summary

Bumped version numbers across multiple packages to 4.6.1.
Added a new React Native example app with configuration files.
Updated AndroidManifest.xml and AppDelegate for proper app setup.
Introduced new utility functions and modules in smart contracts.
Enhanced project structure and build configurations for better performance.

The following files were skipped due to too many changes: examples/react-native-bare-example/ios/ReactNativeBareExample/LaunchScreen.storyboard, examples/react-native-bare-example/src/screens/Home.tsx, account-kit/smart-contracts/src/ma-v2/account/account.ts, account-kit/smart-contracts/src/ma-v2/modules/time-range-module/abis/timeRangeModule.ts, examples/react-native-bare-example/android/app/build.gradle, account-kit/smart-contracts/src/ma-v2/modules/single-signer-validation/abis/singleSignerValidationModule.ts, account-kit/smart-contracts/src/ma-v2/modules/webauthn-validation/abis/webauthnValidation.ts, account-kit/smart-contracts/src/ma-v2/modules/native-token-limit-module/abis/nativeTokenLimitModule.ts, examples/react-native-bare-example/android/gradlew, account-kit/smart-contracts/src/ma-v2/abis/accountFactoryAbi.ts, account-kit/smart-contracts/src/ma-v2/modules/allowlist-module/abis/allowlistModule.ts, account-kit/smart-contracts/src/ma-v2/abis/modularAccountAbi.ts, account-kit/smart-contracts/src/ma-v2/abis/semiModularAccountBytecodeAbi.ts, account-kit/smart-contracts/src/ma-v2/abis/semiModularAccountStorageAbi.ts, examples/react-native-bare-example/ios/ReactNativeBareExample.xcodeproj/project.pbxproj, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-12-12T20:54:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aa-sdk-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 14, 2024 0:42am
aa-sdk-ui-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 14, 2024 0:42am

graphite-app · 2024-12-12T20:54:17Z

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

howydev · 2024-12-12T21:00:31Z

account-kit/smart-contracts/src/ma-v2/account/account.ts

+  const getAccountNonce = async (nonceKey?: bigint): Promise<bigint> => {
+    // uint32 entityId + (bytes1 options) makes a uint40
+    const nonceKeySuffix: bigint =
+      entityId * 256n + (isGlobalValidation ? 1n : 0n);


sanity check: is there a convention/preference to build a bytes40 from a (bytes32 << 8 | bytes8)?

You're actually making a bytes5 I think?

You can do something like:

fromHex(concat(pad(toHex(entityId), 4), pad(toHex(isGlobalValidation), 1)), "bigint")

More verbose but maybe clearer to see what's going on?

like it, prefer this over the current implementation

howydev · 2024-12-12T21:00:51Z

account-kit/smart-contracts/src/ma-v2/account/account.ts

+
+    if (nonceKey) {
+      // comparing the end 40 bytes to suffix
+      if (nonceKey % 2n ** 40n != nonceKeySuffix) {


sanity check: is there a better convention or preferred way to do this?

Blu-J

Adding some comments just to get involved, most of these are meant as discussion and not for fixing things. Probably would need a real reviewer for approval, not familiar enough with the codespace.

Blu-J · 2024-12-12T23:10:53Z

account-kit/smart-contracts/src/ma-v2/account/account.ts

@@ -49,6 +50,8 @@ export type CreateSMAV2AccountAccountParams<
  initialOwner?: Address;
  accountAddress?: Address;
  entryPoint?: EntryPointDef<TEntryPointVersion, Chain>;
+  isGlobalValidation?: boolean;


💬 I always question when booleans are passed around. In this case the global validation is just for the nonce creation in the getAccountNonce right. And At these points I think of other potential apis, like maybe the name could have been NonceBytes, with constants of GLOBAL_VALIDATION_NONCE = 1n, NO_OPS_NONCE = 0n. Or another could have been nonceModifiers (a: nonce) => nonce, basically a fn instead. I don't know what the correct choice is, but every time I see a flag param, I have these questions.

Very thought provoking!

This current flag flips a bit in a byte in getAccountNonce, but there would eventually be another flag (isDeferredAction) that toggles a second bit in the same byte. I was thinking of using the two booleans to create the final byte like this: isDeferredAction ? 1 << 8 : 0 | isGlobalValidation ? 1 : 0

Which implementation would you choose for the above?

So, funny enough, I might still do the boolean flags.
I am trying to create a good thought provoking.
Given that I would probably choose the easiest like has been done, the other would be the fixed point operator as a function would still work.

nonceModifier: NonceModifiers.None, nonceModifier: NonceModifiers.DefferedAction, nonceModifier: NonceModifiers.GlobalValidation, nonceModifier: NonceModifiers.compose(NonceModifiers.GlobalValidation, NonceModifiers.DefferedAction), nonceModifier: NonceModifiers.GlobalValidationAndDefferedAction,

I would go away from the single bit operator. But again, I'm just trying to give another tool for the toolbox.
The problem with the isDefferedAction is seen that we add another flag, and we may add another in the future. If we had two places where the flags where being used, and a new flag was added. The chances of missing the other location for the flag is there. While this fn style lets us do the same operation in multiple areas.

And if we wanted this to be a typed with phantom, we could have done

nonceModifier: NonceModifier type NonceModifier = <N extends bigint & {__type: "NONCE"}>(nonce: N) => N & {__type: "MODIFED_NONCE} /// Implement the type for each of the NonceModifiers NonceModifiers.compose = (...as: NonceModifiers) => as.reduce((a, b) => (nonce) => a(b(nonce)), NonceModifiers.None) as NonceModifier

Blu-J · 2024-12-12T23:16:09Z

account-kit/smart-contracts/src/ma-v2/account/account.ts

  } = config;

+  if (entityId >= 2n ** 32n) {


💬 I see validation then wonder if we should have done a parse instead. There are many articles + videos, but it comes from a more type driven programming. https://lexi-lambda.github.io/blog/2019/11/05/parse-don-t-validate/
And in this case the phantom types could be the parsed proof https://matheusvellone.medium.com/using-phantom-types-to-extreme-type-guard-bec685d6695c
And all this was just to bring up the topic with an example, not to decide what is right and wrong. I usually just like showing other ways of doing things. Getting something out faster, this is usually the better approach.

Love this! Is there a uint32 type we could use here instead of bigint?

ah, phantom types, i see. Ok I'll read up and implement this in! (next week, will leave these in for now)

Please leave them in for now, I just
A. Wanted to show the phantom types
B. Get people a new tool

Because now we have the ability to make an API that reduces the chances of the wrong things fitting into other holes. While not removing the previous tools and API's used previously.

In rust this would be a Newtype https://rust-unofficial.github.io/patterns/patterns/behavioural/newtype.html
But it suffers from more issues compared to TS because TS doesn't care of ordering. There could be some trait type tricks but those also have issues that TS doesn't have.

Blu-J · 2024-12-12T23:23:20Z

account-kit/smart-contracts/src/ma-v2/account/account.ts

+    const nonceKeySuffix: bigint =
+      entityId * 256n + (isGlobalValidation ? 1n : 0n);
+
+    if (nonceKey) {


💬 Please don't change anything, I just want a discussion.
I also tend to see mutation in TS and think of a fn.

const _globalNonce = (nonceKey?: bigint) => { const nonceKeySuffix: bigint = entityId * 256n + (isGlobalValidation ? 1n : 0n); if (nonceKey) { if (nonceKey % 2n ** 40n !== nonceKeySuffix) { throw new Error("Invalid nonceKey"); } } return nonceKeySuffix

Then in the entryPointContract, which is the only place that we use the nonce

return entryPointContract.read.getNonce([ accountAddress, __globalNonce(nonceKey), ]) as Promise<bigint>;

Or could have set it to a variable w/o setting the original

const globalNonce = _globalNonce(nonceKey)

Or something like that. In TS I have an aversion to setting variables, yet in rust I do it all the time. I don't know the correct solution.

Interesting approach. I don't think there is a correct solution in general, but I have a feeling that some of the code here would change once @moldy530 takes a look :P

I also like the solution that @jaypaik has as well with ?? #1209 (comment), it also works in the similar vain of avoid re-assigning a variable.

jaypaik · 2024-12-13T04:29:40Z

account-kit/smart-contracts/src/ma-v2/account/account.ts

  } = config;

+  if (entityId >= 2n ** 32n) {
+    throw new Error("Entity ID must be less than uint32.max");


Prefer to use errors that inherit from BaseError, like this one:

aa-sdk/aa-sdk/core/src/errors/client.ts

Lines 4 to 25 in 17d3771

/**

* Represents an error thrown when a client is not compatible with the expected client type for a specific method. The error message provides guidance on how to create a compatible client.

*/

export class IncompatibleClientError extends BaseError {

override name = "IncompatibleClientError";

/**

* Throws an error when the client type does not match the expected client type.

*

* @param {string} expectedClient The expected type of the client.

* @param {string} method The method that was called.

* @param {Client} client The client instance.

*/

constructor(expectedClient: string, method: string, client: Client) {

super(

[

`Client of type (${client.type}) is not a ${expectedClient}.`,

`Create one with \`createSmartAccountClient\` first before using \`${method}\``,

].join("\n")

);

}

}

If an appropriate custom error doesn't exist, let's create one!

jaypaik · 2024-12-13T04:36:05Z

account-kit/smart-contracts/src/ma-v2/account/account.ts

  } = config;

+  if (entityId >= 2n ** 32n) {


Unrelated, but you can instead do

Suggested change

if (entityId >= 2n ** 32n) {

if (entityId > maxUint32) {

import from viem.

jaypaik · 2024-12-13T05:05:53Z

account-kit/smart-contracts/src/ma-v2/account/account.ts

+  const getAccountNonce = async (nonceKey?: bigint): Promise<bigint> => {
+    // uint32 entityId + (bytes1 options) makes a uint40
+    const nonceKeySuffix: bigint =
+      entityId * 256n + (isGlobalValidation ? 1n : 0n);


You're actually making a bytes5 I think?

You can do something like:

fromHex(concat(pad(toHex(entityId), 4), pad(toHex(isGlobalValidation), 1)), "bigint")

More verbose but maybe clearer to see what's going on?

jaypaik · 2024-12-13T05:55:41Z

account-kit/smart-contracts/src/ma-v2/account/account.ts

+
+    if (nonceKey) {
+      // comparing the end 40 bytes to suffix
+      if (nonceKey % 2n ** 40n !== nonceKeySuffix) {


Something else you could do:

const nonceKeySuffix = concat(pad(toHex(entityId), 4), pad(toHex(isGlobalValidation), 1)); // may need extra checks to ensure nonceKey is of sufficient length and also that both share the same casing if (nonceKey != null && slice(toHex(nonceKey), -5) !== nonceKeySuffix) { // throw error } ... return entryPointContract.read.getNonce([ accountAddress, nonceKey ?? nonceKeySuffix, // may need to convert to bigint ]);

howydev · 2024-12-13T16:13:23Z

Merge activity

Dec 13, 11:13 AM EST: The merge label 'graphite-merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 13, 4:55 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
Dec 13, 5:49 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
Dec 13, 5:50 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
Dec 13, 5:52 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
Dec 13, 5:55 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
Dec 13, 7:35 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
Dec 13, 7:35 PM EST: A user added this pull request to the Graphite merge queue.
Jan 7, 2:39 PM EST: A user removed this pull request from the Graphite merge queue.

howydev · 2024-12-13T16:27:59Z

feat: adds MAv2 client #1212 : 2 dependent PRs (#1214 , #1216 )
feat: add entity id nonce logic #1209 👈 (View in Graphite)
feat: add mav2 account #1208
feat: add all mav2 contract addrs, abis #1207
feat: add mav2 signer #1203
howy/scaffold-v0.8

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

* fix: rn stamper was returning stamp instead of response (#1201) * chore(release): publish v4.6.1 [skip-ci] * feat: add react-native-bare implementation (#1202) * feat: add react-native-bare implementation * fix: fix linting * fix: fix linting * fix: remove unnecessary console.log statements * feat: add signer and account addresses to user logged in screen * fix: updates facebook icon used in ui component (#1196) * feat: add mav2 signer (#1203) # Pull Request Checklist - [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?  --- ## PR-Codex overview This PR introduces a new `SingleSignerValidation` module and related utilities for signature packing and handling user operation signing. It enhances the smart contract framework by implementing various functions and defining the ABI for the module. ### Detailed summary - Added `PackSignatureParams` type and `packSignature` utility in `utils.ts`. - Created `SingleSignerValidationModule` with metadata and encoding functions in `single-signer-validation/module.ts`. - Implemented `singleSignerMessageSigner` function in `single-signer-validation/signer.ts` for signature management. - Defined the ABI for `singleSignerValidation` in `abis/singleSignerValidation.ts`. - Added `MAV2FactoryAbi` and `smaV2Abi` with functions and events related to account management in respective ABI files. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`  --------- Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> Co-authored-by: Alchemy Bot <alchemy-bot@alchemy.com> Co-authored-by: Iyk Azorji <iykazorji@gmail.com>

# Pull Request Checklist - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?  --- ## PR-Codex overview This PR focuses on renaming and restructuring several ABI files and exports in the smart contracts directory, enhancing clarity and consistency in the codebase. ### Detailed summary - Renamed `MAV2FactoryAbi` to `accountFactoryAbi` in `accountFactoryAbi.ts`. - Renamed `smaV2Abi` to `semiModularAccountBytecodeAbi` in `semiModularAccountBytecodeAbi.ts`. - Renamed `singleSignerValidationAbi` to `singleSignerValidationModuleAbi` in `singleSignerValidationModule.ts`. - Updated import statements to reflect the new names. - Added a new `addresses` export containing various module addresses in `utils.ts`. - Introduced new ABI definitions for `paymasterGuardModule`, `timeRangeModule`, `webauthnValidationModule`, `nativeTokenLimitModule`, and `allowlistModule`. - Added ABI definitions for events and error types in the newly created ABI files. > The following files were skipped due to too many changes: `account-kit/smart-contracts/src/ma-v2/abis/semiModularAccountStorageAbi.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

uses a placeholder signer for now  --- ## PR-Codex overview This PR introduces a new smart contract account type called `SMAV2Account`, along with its creation function `createSMAV2Account`. It includes types, parameters, and logic for initializing accounts using a bundler client, handling initial owners, and generating account addresses. ### Detailed summary - Added type `SMAV2Account` for smart contract accounts. - Introduced type `CreateSMAV2AccountParams` for account creation parameters. - Implemented `createSMAV2Account` function to create a new account. - Added logic to handle account initialization and owner address retrieval. - Utilized `createBundlerClient` for client creation. - Integrated `standardExecutor` and `multiOwnerMessageSigner` for account functionality. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

- [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?  --- This PR introduces a new module for single signer validation in the `account-kit` smart contracts. It adds functionality for packing signatures and validating user operations, along with defining the ABI for the single signer validation module and related contracts. - Added `PackSignatureParams` type and `packSignature` utility in `utils.ts`. - Created `SingleSignerValidationModule` with metadata and encoding functions in `single-signer-validation/module.ts`. - Implemented `singleSignerMessageSigner` function in `single-signer-validation/signer.ts` for signing operations. - Defined the ABI for `singleSignerValidation` in `abis/singleSignerValidation.ts`. - Added ABI for `MAV2Factory` and `smaV2` in their respective files. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`  feat: add all mav2 contract addrs, abis (#1207) - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?  --- This PR focuses on renaming and restructuring various ABI exports and imports in the `account-kit/smart-contracts` project, enhancing clarity and organization in the codebase. - Renamed `MAV2FactoryAbi` to `accountFactoryAbi` in `accountFactoryAbi.ts`. - Renamed `smaV2Abi` to `semiModularAccountBytecodeAbi` in `semiModularAccountBytecodeAbi.ts`. - Renamed `singleSignerValidationAbi` to `singleSignerValidationModuleAbi` in `singleSignerValidationModule.ts`. - Updated import statement in `module.ts` for `singleSignerValidationModuleAbi`. - Added new `addresses` export with various module addresses in `utils.ts`. - Introduced `paymasterGuardModuleAbi` in `paymasterGuardModule.ts`. - Added `timeRangeModuleAbi` in `timeRangeModule.ts`. - Added `webauthnValidationModuleAbi` in `webauthnValidation.ts`. - Added `nativeTokenLimitModuleAbi` in `nativeTokenLimitModule.ts`. - Added `allowlistModuleAbi` in `allowlistModule.ts`. - Introduced `modularAccountAbi` in `modularAccountAbi.ts`. - Introduced `semiModularAccountStorageAbi` in `semiModularAccountStorageAbi.ts`. > The following files were skipped due to too many changes: `account-kit/smart-contracts/src/ma-v2/abis/semiModularAccountStorageAbi.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`  feat: add scaffold for ma v2 chore: lint feat: add scaffold for ma v2 feat: add all mav2 contract addrs, abis (#1207) - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?  --- This PR introduces several new smart contract ABIs and address constants for a modular account system, enhancing functionality for various modules, including validation and execution. - Added `addresses` constant with various module addresses in `addresses.ts`. - Introduced ABIs for `paymasterGuardModule`, `timeRangeModule`, `webauthnValidation`, `nativeTokenLimitModule`, `allowlistModule`, and `maV2`. - Each ABI includes functions, events, and errors relevant to their respective modules. > The following files were skipped due to too many changes: `account-kit/smart-contracts/src/ma-v2/abis/smaStorage.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`  feat: add mav2 account feat: add entity id nonce logic feat: x feat: a feat: x

howydev added 2 commits December 9, 2024 18:57

feat: add scaffold for ma v2

1f7539f

chore: lint

f0a3806

howydev requested review from moldy530, rthomare, dancoombs, mokok123, dphilipson and linnall as code owners December 12, 2024 20:54

howydev force-pushed the howy/add-get-nonce branch from 5d1c446 to 9c637a5 Compare December 12, 2024 20:57

howydev commented Dec 12, 2024

View reviewed changes

howydev requested a review from Blu-J December 12, 2024 21:05

vercel bot deployed to Preview – aa-sdk-ui-demo December 12, 2024 21:06 View deployment

vercel bot deployed to Preview – aa-sdk-ui-demo December 12, 2024 21:16 View deployment

vercel bot deployed to Preview – aa-sdk-site December 12, 2024 21:19 View deployment

Blu-J reviewed Dec 12, 2024

View reviewed changes

jaypaik reviewed Dec 13, 2024

View reviewed changes

howydev added the graphite-merge-queue label Dec 13, 2024

graphite-app bot changed the base branch from howy/add-mav2-account to main December 13, 2024 16:13

howydev force-pushed the howy/add-get-nonce branch from a013c85 to 94ebe8d Compare December 13, 2024 16:27

howydev changed the base branch from main to howy/add-mav2-account December 13, 2024 16:27

linnall mentioned this pull request Dec 13, 2024

feat: add mav2 signer #1203

Merged

7 tasks

howydev mentioned this pull request Dec 13, 2024

feat: add all mav2 contract addrs, abis #1207

Merged

7 tasks

This was referenced Dec 13, 2024

feat: add mav2 account #1208

Merged

feat: adds MAv2 client #1212

Closed

vercel bot deployed to Preview – aa-sdk-ui-demo December 13, 2024 16:29 View deployment

howydev force-pushed the howy/add-get-nonce branch from c6709ec to 6e56cc3 Compare December 13, 2024 22:51

howydev changed the base branch from howy/add-mav2-account to main December 13, 2024 22:51

howydev force-pushed the howy/add-get-nonce branch from 6e56cc3 to 1109e77 Compare December 13, 2024 22:52

howydev changed the base branch from main to graphite-base/1209 December 13, 2024 22:52

howydev changed the base branch from graphite-base/1209 to howy/add-mav2-account December 13, 2024 22:52

howydev force-pushed the howy/add-get-nonce branch from 1109e77 to 3e9e0e7 Compare December 13, 2024 22:55

howydev changed the base branch from howy/add-mav2-account to main December 13, 2024 22:55

howydev changed the base branch from main to graphite-base/1209 December 13, 2024 22:55

linnall force-pushed the graphite-base/1209 branch from 309b792 to ec136e9 Compare December 13, 2024 23:10

linnall force-pushed the howy/add-get-nonce branch from 3e9e0e7 to 840636a Compare December 13, 2024 23:10

linnall mentioned this pull request Dec 13, 2024

feat: adds install validation types #1216

Closed

7 tasks

vercel bot deployed to Preview – aa-sdk-ui-demo December 13, 2024 23:18 View deployment

vercel bot deployed to Preview – aa-sdk-site December 13, 2024 23:29 View deployment

howydev added 2 commits December 13, 2024 19:28

howydev force-pushed the howy/add-get-nonce branch 4 times, most recently from 69be16f to de6e837 Compare December 14, 2024 00:34

howydev force-pushed the graphite-base/1209 branch from ec136e9 to 309b792 Compare December 14, 2024 00:34

howydev changed the base branch from graphite-base/1209 to main December 14, 2024 00:35

howydev force-pushed the howy/add-get-nonce branch from de6e837 to d7346a7 Compare December 14, 2024 00:35

howydev force-pushed the howy/add-get-nonce branch from d7346a7 to 72a46ce Compare December 14, 2024 00:36

howydev closed this Dec 14, 2024

vercel bot deployed to Preview – aa-sdk-ui-demo December 14, 2024 00:39 View deployment

vercel bot deployed to Preview – aa-sdk-site December 14, 2024 00:42 View deployment

howydev mentioned this pull request Dec 14, 2024

feat: basic ma v2 sdk integrations #1220

Merged

graphite-app bot removed the graphite-merge-queue label Jan 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add entity id nonce logic #1209

feat: add entity id nonce logic #1209

howydev commented Dec 12, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 12, 2024 •

edited

Loading

graphite-app bot commented Dec 12, 2024

howydev Dec 12, 2024

jaypaik Dec 13, 2024

howydev Dec 14, 2024

howydev Dec 12, 2024

Blu-J left a comment

Blu-J Dec 12, 2024

howydev Dec 13, 2024 •

edited

Loading

howydev Dec 13, 2024

Blu-J Dec 13, 2024

Blu-J Dec 12, 2024

howydev Dec 13, 2024

howydev Dec 13, 2024

Blu-J Dec 13, 2024

Blu-J Dec 13, 2024

Blu-J Dec 12, 2024 •

edited

Loading

howydev Dec 13, 2024

Blu-J Dec 13, 2024

jaypaik Dec 13, 2024

jaypaik Dec 13, 2024

jaypaik Dec 13, 2024

jaypaik Dec 13, 2024 •

edited

Loading

howydev commented Dec 13, 2024 •

edited by graphite-app bot

Loading

howydev commented Dec 13, 2024 •

edited

Loading

	/**
	* Represents an error thrown when a client is not compatible with the expected client type for a specific method. The error message provides guidance on how to create a compatible client.
	*/
	export class IncompatibleClientError extends BaseError {
	override name = "IncompatibleClientError";

	/**
	* Throws an error when the client type does not match the expected client type.
	*
	* @param {string} expectedClient The expected type of the client.
	* @param {string} method The method that was called.
	* @param {Client} client The client instance.
	*/
	constructor(expectedClient: string, method: string, client: Client) {
	super(
	[
	`Client of type (${client.type}) is not a ${expectedClient}.`,
	`Create one with \`createSmartAccountClient\` first before using \`${method}\``,
	].join("\n")
	);
	}
	}

feat: add entity id nonce logic #1209

feat: add entity id nonce logic #1209

Conversation

howydev commented Dec 12, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

vercel bot commented Dec 12, 2024 • edited Loading

graphite-app bot commented Dec 12, 2024

How to use the Graphite Merge Queue

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Blu-J left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

howydev Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Blu-J Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaypaik Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

howydev commented Dec 13, 2024 • edited by graphite-app bot Loading

Merge activity

howydev commented Dec 13, 2024 • edited Loading

How to use the Graphite Merge Queue

howydev commented Dec 12, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 12, 2024 •

edited

Loading

howydev Dec 13, 2024 •

edited

Loading

Blu-J Dec 12, 2024 •

edited

Loading

jaypaik Dec 13, 2024 •

edited

Loading

howydev commented Dec 13, 2024 •

edited by graphite-app bot

Loading

howydev commented Dec 13, 2024 •

edited

Loading