Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win build #4

Closed
wants to merge 22 commits into from
Closed

Win build #4

wants to merge 22 commits into from

Conversation

kkirstein
Copy link
Contributor

  • add symbol definitions for Windows build
  • fix function signature for Windows in remutex package
  • add build instruction for Windows to Readme

@kkirstein
Copy link
Contributor Author

@aldanor I just created a pull request with the Windows-enabled version. I added some build instructions to the Readme. I also had a short look at appveyor, looks like a good option, although I have no experience with CI from the cloud.
As I will be on vacation for the rest of the week, please don't expect any answers from me during the next days, I will take a closer look at appveyor next week.

@aldanor
Copy link
Owner

aldanor commented Jun 16, 2015

@kkirstein

Thanks a lot for the PR! I won't have time to look at it in detail till weekend but it looks good from the first glance -- although I have no way of testing it actually works on Windows right now other than taking your word on it -- would be really great to try and set up a CI build for it.

I have no experience with Appveyor but it looks reasonable. Maybe you could take a look at PyTables build? See PR here: PyTables/PyTables#426

As for MSVC interoperability, it looks like there's some very recent ongoing work going upstream, see here for more details:

Ideally, we'd want to support both mingw and msvc builds, if possible at all.

@kkirstein
Copy link
Contributor Author

@aldanor Thanks, for pointing to the discussions on rust-lang!

@aldanor
Copy link
Owner

aldanor commented Jun 22, 2015

@kkirstein You're welcome! By the way, I've noticed that many rust-lang repos were set up for appveyor builds about a week ago -- see, for instance, rust-lang/regex@1be2fee -- maybe that could be a good starting point.

Good call with #[inline], too.

@aldanor aldanor mentioned this pull request Jul 5, 2015
@aldanor
Copy link
Owner

aldanor commented Jul 6, 2015

Closed in favor of #7.

@aldanor aldanor closed this Jul 6, 2015
magnusuMET added a commit to magnusuMET/hdf5-rust that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants