Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic appveyor ci #6

Closed
wants to merge 9 commits into from
Closed

basic appveyor ci #6

wants to merge 9 commits into from

Conversation

kkirstein
Copy link
Contributor

This contains a basic appveyor integration:

  • configuration is completely done with appveyor.yml (no GUI setup)
  • a binary verson of hdf5.dll is downloaded from GitHub
  • builds for rust 1.1 & nightly are checked

Todos:

  • add build of hdf5 lib (needs cmake & MinGW)
  • add 32bit build (?)
  • add *-msvc target of rust

You have to setup a project on appveyor for your repo and change the link of the build status badge in Readme for this to work in your repo.

@andreabedini
Copy link

my 2c on the README: it makes total sense of HDF people to use MSVC on Windows rather than mingw. Actually Rust is supposed to work with MSVC too and they are going to get there soon see e.g. rust-lang/rfcs#1061.

edit: ... and great work everyone!

@aldanor
Copy link
Owner

aldanor commented Jul 5, 2015

@kkirstein This is great, thanks a lot! I will try to set up the appveyor repo tonight and then merge this in.

Could you please squash this PR?

@aldanor
Copy link
Owner

aldanor commented Jul 5, 2015

@andreabedini we have already discussed this in #4 :) It would be best to support both mingw and msvc once it's out of course.

@andreabedini
Copy link

@aldanor sorry, I have been out of the loop :)

@kkirstein
Copy link
Contributor Author

@aldanor I will try to squash this PR, so you don't see all my flaws (I'm not an Git-expert and already merged my branch, but it should be possible anyway..).
@andreabedini mcvs target is already on my todo list, but with low prio. I should give it fast try.

+ setup rust

! fix ps environment variable

! fix rust installer name

! fix rust installer name (now really)

+ run cargo test

! fix test_script typo

! use WebRequest for file download

! fix ps script indentation

+ generate missing folder

! use github release for hdf5 binary

+ prepare for muliple rust versions

! enable build with nightly rust

! fix environment indent

! fix rust installer name for multiple versions

+ appveyor build status badge

! alt-test for appveyor build status badge
@kkirstein
Copy link
Contributor Author

@aldanor There is another PR with a squashed commit from my appveyor branch.

@aldanor
Copy link
Owner

aldanor commented Jul 6, 2015

Closed in favor of #7.

@aldanor aldanor closed this Jul 6, 2015
@aldanor
Copy link
Owner

aldanor commented Jul 6, 2015

@kkirstein You could have just git push --force so you wouldn't have to create a new PR, I think :)

magnusuMET added a commit to magnusuMET/hdf5-rust that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants