[HTML formatter] Use span for .line, put code inside <code>
#572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently only "phrasing content" are permitted inside `pre` and `code`, and `div` is not one of them, so replace it with `span`, `div` wasn't necessary anyway. Also it makes sense to put code inside `code` tag(except for line numbers). Removed `overflow:auto` and `width: auto` as they didn't seem to be necessary and actually prevented horizontal scroll bar to appear when content didn't fit in the viewport.
alecthomas
approved these changes
Nov 10, 2021
QuLogic
added a commit
to QuLogic/go-org
that referenced
this pull request
Feb 28, 2022
- 0.9.2 added `tabindex="0"` to `pre`: alecthomas/chroma#515 - 0.10.0 changed around divs and spans, pre and code alecthomas/chroma#571 alecthomas/chroma#572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently only "phrasing content" are permitted inside
preandcode, anddivis not one of them, so replaced it withspan,divwasn't necessary anyway.Also it makes sense to put code inside
codetag(except for line numbers).Removed
overflow:autoandwidth: autofromtableas they didn't seem to be necessary and actually prevented horizontal scroll bar to appear when content didn't fit in the viewport.