Snapshots are allowed when running gitflow release start

[manderson23]

If I run the following command with snapshot dependencies in the pom

mvn gitflow:release-start -DpushRemote=true -DversionDigitToIncrement=1 -DcommitDevelopmentVersionAtStart=true

the command succeeds even though allowSnapshots should be using the default value of false.

I think this is a regression introduced when an issue related to snapshots that I previously reported was fixed - #169

[aleksandr-m]

@manderson23 Cannot reproduce. Can you create a simple test project.

[Opa-]

I had the same issue and had to downgrade the plugin to v1.11.0

[glianeric]

I have created a very, very dirty 'fix' for this, which is why I'm not submitting it as a PR right now. I basically added an enforcer run just before the merge, which runs the requirereleasedeps enforcer rule on the project. I still believe that fixing up @aleksandr-m function is a much better solution, but for now I can run with 'allowSnapshots', while my addition catches any unwanted snapshots.

[aleksandr-m]

@manderson23 @Opa- @glianeric reprex please or mcve or mwe.

[aekrylov]

@aleksandr-m It seems that snapshots versions aren't checked properly when the version is defined in a property. Here's a minimal example: https://github.com/aekrylov/snapshots-reprex/tree/develop

[manderson23]

In my case all versions are defined in properties.

…

On Thu, 19 Sep 2019, 09:34 Anton Krylov, ***@***.***> wrote: @aleksandr-m <https://github.com/aleksandr-m> It seems that snapshots versions aren't checked properly when the version is defined in a property. Here's a minimal example: https://github.com/aekrylov/snapshots-reprex/tree/develop — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#182?email_source=notifications&email_token=AAM3JIMX3C4DJG7PTPD4BJ3QKM2QBA5CNFSM4HYXQRW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7CVZ4I#issuecomment-533028081>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM3JIK22MXMQCA4IZOS2PDQKM2QBANCNFSM4HYXQRWQ> .

[cidus]

I have encountered this issue as well, and have verified it with a dummy project.

This will be properly checked:

	<dependencies>
		<dependency>
			<groupId>world.hello</groupId>
			<artifactId>dummy-library</artifactId>
			<version>1.0.0-SNAPSHOT</version>
		</dependency>
	</dependencies>

This will not:

	<properties>
		<dummy-library.version>1.0.0-SNAPSHOT</dummy-library.version>
	</properties>
	<dependencies>
		<dependency>
			<groupId>world.hello</groupId>
			<artifactId>dummy-library</artifactId>
			<version>${dummy-library.version}</version>
		</dependency>
	</dependencies>

[cidus]

I replaced readModel with reloadProject which uses ProjectBuilder in order to recompute all project info, it should resolve transitive dependencies and property versions.
PR #204