Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reloads project info from pom.xml file using ProjectBuilder #204

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Conversation

cidus
Copy link
Contributor

@cidus cidus commented Oct 8, 2019

I'm not sure ProjectBuilder is part of the Maven Plugin API, but it works.
This should fix #200 fix #182

@aleksandr-m
Copy link
Owner

Looks promising. I'll take a closer look and run some tests.

@vinsgithub
Copy link

vinsgithub commented Oct 25, 2019

Looks promising. I'll take a closer look and run some tests.

I can confirm. I've cherry-picked cidus' commit into Aleksandr's master and it works. @aleksandr-m , can you please consider my test case after merging cidus' commit?

Thank you

@aleksandr-m aleksandr-m merged commit 3486430 into aleksandr-m:master Nov 3, 2019
@aleksandr-m
Copy link
Owner

@cidus Thank you.

@vinsgithub Can you prepare another PR with your test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants