Banxa | UI redesign #1026
Open
Banxa | UI redesign #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nop33
commented
Dec 9, 2024
•
nop33
commented
To be used in the LandingScreen
Introduce new modal system with BuyModal (fix Banxa reload issue)
Tried a LOT to use imprative handle to manage ref and closing bottom modal imperatively. But it was just too complicated and messy. I'll find another way.
Will investigate another way. This works, but we keep some variables in memory after the modal is closed. Not a big deal, but we can do better.
Still not there yet
TS black magic 🧙♂ ️
Fix android
Fix contacts screens
Fix ios font ilias
Fix dashboard icons
Fix iOS font
Add light theme variant in main animation
nop33
commented
Dec 18, 2024
Comment on lines
+555
to
+581
| const openWalletConnectSessionProposalModal = useCallback( | ||
| () => | ||
| sessionProposalEvent && | ||
| dispatch( | ||
| openModal({ | ||
| name: 'WalletConnectSessionProposalModal', | ||
| props: { | ||
| approveProposal, | ||
| rejectProposal, | ||
| proposalEvent: sessionProposalEvent | ||
| } | ||
| case 'alph_signUnsignedTx': { | ||
| const { signerAddress, signerKeyType, unsignedTx } = requestEvent.params.request | ||
| .params as SignUnsignedTxParams | ||
| }) | ||
| ), | ||
| [approveProposal, dispatch, rejectProposal, sessionProposalEvent] | ||
| ) | ||
|
|
||
| const fromAddress = addressIds.find((address) => address === signerAddress) | ||
| const onSessionProposal = useCallback( | ||
| async (sessionProposalEvent: SessionProposalEvent) => { | ||
| console.log('📣 RECEIVED EVENT PROPOSAL TO CONNECT TO A DAPP!') | ||
| console.log('👉 ARGS:', sessionProposalEvent) | ||
| console.log('⏳ WAITING FOR PROPOSAL APPROVAL OR REJECTION') | ||
|
|
||
| if (!fromAddress) { | ||
| return respondToWalletConnectWithError(requestEvent, { | ||
| message: "Signer address doesn't exist", | ||
| code: WALLETCONNECT_ERRORS.SIGNER_ADDRESS_DOESNT_EXIST | ||
| }) | ||
| } | ||
| setSessionProposalEvent(sessionProposalEvent) | ||
| openWalletConnectSessionProposalModal() | ||
| }, | ||
| [openWalletConnectSessionProposalModal] | ||
| ) |
There was a problem hiding this comment.
This doesn't work.
setSessionProposalEvent(sessionProposalEvent)
openWalletConnectSessionProposalModal()
because in the openWalletConnectSessionProposalModal function, sessionProposalEvent has not yet received a value before it's called.
There was a problem hiding this comment.
Same problem with openWalletConnectSessionRequestModal.
nop33
added a commit
that referenced
this pull request
Dec 19, 2024
Related to #947 Closes #856 Also see: #1026 (review)
nop33
added a commit
that referenced
this pull request
Dec 19, 2024
Related to #947 Also see: #1026 (review)
nop33
added a commit
that referenced
this pull request
Dec 19, 2024
Related to #947 Closes #856 Also see: #1026 (review)
nop33
added a commit
that referenced
this pull request
Dec 19, 2024
Related to #947 Also see: #1026 (review)
nop33
added a commit
that referenced
this pull request
Dec 19, 2024
Related to #947 Closes #856 Also see: #1026 (review)
nop33
added a commit
that referenced
this pull request
Dec 19, 2024
Related to #947 Also see: #1026 (review)
mvaivre
pushed a commit
that referenced
this pull request
Dec 19, 2024
Related to #947 Closes #856 Also see: #1026 (review)
mvaivre
pushed a commit
that referenced
this pull request
Dec 19, 2024
Related to #947 Also see: #1026 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.