Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with React plugins and zabbix source #823

Closed
maxlehot1234 opened this issue Oct 21, 2019 · 5 comments
Closed

Issue with React plugins and zabbix source #823

maxlehot1234 opened this issue Oct 21, 2019 · 5 comments
Labels
comp: alerting type/bug
Milestone
3.10.5

Comments

@maxlehot1234
Copy link

maxlehot1234 commented Oct 21, 2019 •
edited
Loading

Hi everyone,

I post something on the grafana github, but ticket was closed since I am the only one with that issue.
I copy-paste base information here so you can get an idea of the issue instead of using the link below.

What happened:
BarGauge plugin stop working. No reason why...
Everything works if I enable/disable the Transparent option into grafana, but directly when page reload, datas disappear, but that was not a fix of course.

What you expected to happen:
I want the bar gauge to work on every host. No idea which things I need to put here

How to reproduce it (as minimally and precisely as possible):
I setup groups on Zabbix.
I setup a dashboard where I can choose the zabbix group and zabbix host from the selected group.
I have a host that have low disk space and it crash the bar gauge plugin for this host only.
I need to choose another host and refresh the page to get the bar gauge work for the other host.
Example:
image

Like you can see, we see the thing that allow us to resize the plugin (bar gauge), but no data in it, cause it crash for the host.

For the other hosts, it looks like this:
image

Environment:

  • Grafana version: Grafana v6.4.2 (443a0ba)
  • Data source type & version: Zabbix
  • OS Grafana is installed on: CentOS6
  • User OS & Browser: Win10 1903 + chrome 76.0.3809.132

I got console error in Chrome when I load Bar Gauge into grafana:
image

I check with @ryantxu: https://github.com/ryantxu and he remote my computer to see everything and he realize that something was wrong with how zabbix works with React which is used by Bar Gauge and Gauge plugin into Grafana. (I send him this ticket link, so he can reply and add more informations if needed)

You can get lot more informations here if you want:
grafana/grafana#19213

Software versions

Grafana Zabbix Grafana-Zabbix Plugin
6.4.3 4.2.6 3.10.4

EDIT: Update to 6.4.3 of grafana and same issue.

Thanks again for everything and hope we can see this working, since we use it a lot here and Bar gauge seems to "crash" when a trugger goes under 15% in zabbix.
@ryantxu
Copy link
Member

ryantxu commented Oct 22, 2019

I dug into this a bit.... the issue is with setting alert state on the panel breaks any react based panels in grafana. Setting the classes directly with:

https://github.com/alexanderzobnin/grafana-zabbix/blob/ca082c98a16afc231cd05e3c83c44a969d6434a5/src/datasource-zabbix/zabbixAlerting.service.js#L16

changes the style so it is width+height == 0

@maxlehot1234
Copy link
Author

@alexanderzobnin Tag me if you need me to test something since it seems that I am the only one with this issue.
I can test a version in advance if you want. just let me know.

This bug prevent our company to have a nice preview of our servers disk space left.

Thanks again and have a nice day

@alexanderzobnin alexanderzobnin added this to the 3.11 milestone Oct 28, 2019
@alexanderzobnin
Copy link
Collaborator

Fix will be included in the upcoming release.

@maxlehot1234
Copy link
Author

I try to add the change in the file and restart Grafana, but still get the same problem :(

Lets see with 3.11 when it will release to see if everything was fix :)

Thanks in advanced

@maxlehot1234
Copy link
Author

@alexanderzobnin Any way to help to fix this instead of need to wait for an update that can be release in few weeks?

Thanks in advance and have a nice day/night

@torkelo torkelo mentioned this issue Dec 3, 2019
Closed
@alexanderzobnin alexanderzobnin modified the milestones: 3.11, 3.10.5 Dec 25, 2019
alexanderzobnin added a commit that referenced this issue Dec 30, 2019
@vignesh-reddy @mjtrangoni @alexanderzobnin
Backend: Merge master into the backend branch (#845)
c300deb 
* CI: fix shellcheck issues (#789)

Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

* annotations: fix options in grafana 6.x, fix #813

* fix function editor in Grafana 6.4, closes #810

* add typings for grafana packages

* Add $__range_series variable for calculating function over the whole series, #531

* fix tests

* Don't set alert styles for react panels, fix #823

* docs: add range variables

* docs: percentile reference

* fix codespell

Co-authored-by: Mario Trangoni <mario@mariotrangoni.de>
Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>
alexanderzobnin added a commit that referenced this issue Jan 15, 2020
@alecxvs @mjtrangoni
@alexanderzobnin @dependabot @mr-ns @memfiz
[Backend] Merge 'master' changes into the backend (#875)
92e7761 
* CI: fix shellcheck issues (#789)

Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

* annotations: fix options in grafana 6.x, fix #813

* fix function editor in Grafana 6.4, closes #810

* add typings for grafana packages

* Add $__range_series variable for calculating function over the whole series, #531

* fix tests

* Don't set alert styles for react panels, fix #823

* docs: add range variables

* docs: percentile reference

* fix codespell

* update packages (build with node 12)

* update circleci node image to 12

* fix test configuration (babel)

* Fix 817 (#851)

* problems: update panel schema

* update packages (build with node 12)

* problems: use datasource from target

* problems: fix query editor after schema update

* problems: fix list layout

* update circleci node image to 12

* fix tests

* build(deps-dev): bump lodash from 4.17.10 to 4.17.13 (#852)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.10...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>

* fix packages security alerts

* problems: fix tags adding and removal

* fix adding func from typeahead, closes #468

* update change log

* bump plugin version to 3.10.5

* problems: fix tag removal (list layout)

* Fix percentile() function, closes #862 (#863)

Like the other aggregation functions, the datapoints need to be sorted in
time before calling groupBy_perf().

* Update copyright, happy New Year!

* fix not acknowledged problem color with a message (#858)

* fix not acknowledged problem color with a message

* fix not acknowledged problem color with a message, closes #857

* Variable query editor (#856)

* refactor: convert module to typescript

* refactor: covert utils to typescript

* variable query editor WIP

* variable editor: fix type error after grafana/ui update

* variable editor: use FormLabel from grafana/ui

* variable editor: refactor

* variable editor: input validation and highlights

* variable editor: fix tests

* variable query: fix backward compatibility with empty queries

* fix linter errors

* variable editor: fix variable replacement in queries

* Fixes for backend

Co-authored-by: Mario Trangoni <mario@mariotrangoni.de>
Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Reibert <mreibert@netskope.com>
Co-authored-by: memfiz <arnis.civciss@gmail.com>
@alexanderzobnin alexanderzobnin mentioned this issue Jan 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: alerting type/bug
Projects
None yet
Milestone
3.10.5
Development

No branches or pull requests
3 participants
@ryantxu @alexanderzobnin @maxlehot1234