-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the API to more closely bind libcurl #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just get CI passing for now
This was referenced May 12, 2016
Closed
This was referenced May 12, 2016
Closed
May want to do this in a more rustic fashion later on.
More ergonomic but requires an allocation. Deemed worth the tradeoff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are a complete rewrite of the API of this crate based on binding more closely to the libcurl APIs themselves. This was originally started as a reimplementation to expose more features, but along the way I found that providing the same existing API may end up being more difficult than it's worth. In the end this rewrite performs a few things:
ctest
I'm gonna tag a bunch of issues and PRs as being closed by this, but I'd love to get some feedback on this as well! This PR currently requires the beta version of Rust as it uses the soon-to-be-stable
std::panic
APIs, so I won't make a release until those hit stable.API docs
Closes #5
Closes #6
Closes #7
Closes #8
Closes #10
Closes #33
Closes #41
Closes #58
Closes #61
Closes #63
Closes #75
Closes #81
Closes #82
Closes #83
Closes #85
Closes #92
Closes #93
Closes #95
Closes #102
Closes #104