Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make response body optional #75

Closed
wants to merge 2 commits into from

Conversation

posix4e
Copy link

@posix4e posix4e commented Jun 12, 2015

This is a first stab at #5. I'm curious what methods can have optional body. Should we set it to None automatically if response is set to 0?

@posix4e
Copy link
Author

posix4e commented Jun 12, 2015

updated this pull request to remove the file I inadvertently added

@carllerche
Copy link
Contributor

A good start. I was hoping to have the body be set to None when the response doesn't actually contain a response body (like the response to a HEAD request).

@posix4e
Copy link
Author

posix4e commented Aug 19, 2015

Check the head test and tell me if that's what you are thinking.

@posix4e
Copy link
Author

posix4e commented Sep 4, 2015

OK updated the patch again. I can't say I am happy with how the code turned out , and would be into suggestions to make things cleaner. However, it does solve the issue

@alexcrichton
Copy link
Owner

Hey @posix4e, I'm taking over the curl crate for now and I've got an API rewrite over at #105 which I believe should address this as well. If you'd like to take a look though feel free!

I hope to soon get around to #74 and bind the multi API but we'll take some baby steps first!

@posix4e
Copy link
Author

posix4e commented May 12, 2016

Very good sir!

On Thu, May 12, 2016 at 10:21 AM Alex Crichton notifications@github.com
wrote:

Hey @posix4e https://github.com/posix4e, I'm taking over the curl crate
for now and I've got an API rewrite over at #105
#105 which I believe
should address this as well. If you'd like to take a look though feel free!

I hope to soon get around to #74
#74 and bind the multi
API but we'll take some baby steps first!


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#75 (comment)

Sent from my mobile 4045076749
Alex Newman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants