An example of curl_multi #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Trying to catch up. I definitely want to get curl multi bound. Glancing through the PR though, it looks like there is a lot of duplication. Any way to try to avoid duplicating definitions? |
|
No worries. Notice CurlM vs Curl for a lot of the options. What dups are you most worried about? |
|
It's a bit hard for me to follow (and I have lost a lot of context), but I'm noticing some duplication like |
|
So i removed the easy.rs file altogether. Is this any clearer? |
|
Ok, I've started binding the multi interface in #109, so I'm gonna close this now. Sorry for the delayed response :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking at adding support for the curl_multi api. This creates a lot of duplication (which I have tried to avoid) and most likely we will need a different library that pulls in eventual and mio to actually make use of the bindings. I'm working on one called micro-hyper. Consider this pull a demonstration and a WIP. The question I have is what the api should look like.