Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with latest closure compiler #30

Closed
alexeagle opened this issue May 9, 2017 · 5 comments
Closed

Doesn't work with latest closure compiler #30

alexeagle opened this issue May 9, 2017 · 5 comments

Comments

@alexeagle
Copy link
Owner

Upgrading from v20170409 to v20170423 breaks the Angular example:

Release notes: https://github.com/google/closure-compiler/wiki/Releases#april-23-2017-v20170423
Broken build:
https://circleci.com/gh/alexeagle/closure-compiler-angular-bundling/82

node_modules/@angular/core/@angular/core.js:5607: ERROR - variable System is undeclared
        return System.import(module)
               ^^^^^^

node_modules/@angular/platform-browser/@angular/platform-browser.js:3091: ERROR - variable Hammer is undeclared
        const /** @type {?} */ mc = new Hammer(element);
                                        ^^^^^^

node_modules/moment/moment.js:8: ERROR - variable module is undeclared
    typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
                                          ^^^^^^

node_modules/moment/moment.js:9: ERROR - variable define is undeclared
    typeof define === 'function' && define.amd ? define(factory) :
           ^^^^^^

node_modules/moment/moment.js:399: ERROR - variable require is undeclared
                require('./locale/' + name);
                ^^^^^^^

node_modules/rxjs/util/root.js:8: ERROR - variable global is undeclared
else if (typeof global == 'object' && global.global === global) {
                ^^^^^^

cc @StephenFluin
@alexeagle
Copy link
Owner Author

alexeagle commented May 9, 2017 •
edited
Loading

@ChadKillingsworth do you happen to know what the breaking change was? Seems like some default externs have moved or been removed?

@ChadKillingsworth
Copy link

No not at all - but this is the second report I've seen of something similar.

@alexeagle
Copy link
Owner Author

alexeagle commented May 10, 2017 •
edited
Loading

@MatrixFrog - known issue? should I file it on the closure-compiler issue tracker?

@MatrixFrog
Copy link

I haven't seen this before, yeah please file it.

@alexeagle alexeagle mentioned this issue May 10, 2017
Closed
devversion added a commit to devversion/material2 that referenced this issue May 21, 2017
@devversion
build: upgrade dev dependencies
1bc77d3 
* Upgrades outdated development dependencies to the latest versions.
* Skipped upgrading Autoprefixer and UglifyJS due to some bigger breaking changes
* Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30
devversion added a commit to devversion/material2 that referenced this issue May 21, 2017
@devversion
build: upgrade dev dependencies
6a1f3b2 
* Upgrades outdated development dependencies to the latest versions.
* Skipped upgrading Autoprefixer due to a breaking change with the Browserlist.
* Skipped upgrading UglifyJS due to unresolved issues in UglifyJS3
* Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30
* Skipped upgrading jasmine types because they now enforce types in `expect` calls (which is nice) but for Protractor the `expect` automatically unwraps promises (See angular/protractor#4176)
@devversion devversion mentioned this issue May 21, 2017
Merged
devversion added a commit to devversion/material2 that referenced this issue May 21, 2017
@devversion
build: upgrade dev dependencies
2e68ada 
* Upgrades outdated development dependencies to the latest versions.
* Skipped upgrading Autoprefixer due to a breaking change with the Browserlist.
* Skipped upgrading UglifyJS due to unresolved issues in UglifyJS3
* Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30
* Skipped upgrading jasmine types because they now enforce types in `expect` calls (which is nice) but for Protractor the `expect` automatically unwraps promises (See angular/protractor#4176)
devversion added a commit to devversion/material2 that referenced this issue May 22, 2017
@devversion
build: upgrade dev dependencies
6253a0e 
* Upgrades outdated development dependencies to the latest versions.
* Skipped upgrading Autoprefixer due to a breaking change with the Browserlist.
* Skipped upgrading UglifyJS due to unresolved issues in UglifyJS3
* Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30
* Skipped upgrading jasmine types because they now enforce types in `expect` calls (which is nice) but for Protractor the `expect` automatically unwraps promises (See angular/protractor#4176)
tinayuangao pushed a commit to angular/components that referenced this issue May 22, 2017
@devversion @tinayuangao
build: upgrade dev dependencies (#4707)
a41ef27 
* build: upgrade dev dependencies

* Upgrades outdated development dependencies to the latest versions.
* Skipped upgrading Autoprefixer due to a breaking change with the Browserlist.
* Skipped upgrading UglifyJS due to unresolved issues in UglifyJS3
* Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30
* Skipped upgrading jasmine types because they now enforce types in `expect` calls (which is nice) but for Protractor the `expect` automatically unwraps promises (See angular/protractor#4176)

* Lock jasmine types
@alexeagle
Copy link
Owner Author

Moving issues from this repo to angular/closure-demo

@alexeagle alexeagle mentioned this issue Sep 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @MatrixFrog @ChadKillingsworth