build: upgrade dev dependencies #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/upgrade-deps
branch
3 times, most recently
from
6a1f3b2
to
2e68ada
Compare
* Upgrades outdated development dependencies to the latest versions. * Skipped upgrading Autoprefixer due to a breaking change with the Browserlist. * Skipped upgrading UglifyJS due to unresolved issues in UglifyJS3 * Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30 * Skipped upgrading jasmine types because they now enforce types in `expect` calls (which is nice) but for Protractor the `expect` automatically unwraps promises (See angular/protractor#4176)
devversion
force-pushed
the
build/upgrade-deps
branch
from
2e68ada
to
6253a0e
Compare
|
Don't we not use autoprefixer any more? For the others, can you add a comment in the |
|
We still use Autoprefixer to figure out if a property needs to have a prefix. @crisbeto implemented it in the stylelint rule. Also I'm not sure if comments work inside of |
jelbourn
approved these changes
May 22, 2017
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectcalls (which is nice) but for Protractor theexpectautomatically unwraps promises (See Typings issue since @types/jasmine update protractor#4176)Note: Tests are failing due to infinite loops in the latest Jasmine version. Rebasing after #4662 is merged!