Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6.1 compatibility / Fix deprecation warnings in Rails 6.0 #6

Merged

Conversation

danderozier
Copy link
Contributor

Using this gem on Rails 6.0 results in a deprecation warning: DEPRECATION WARNING: Module#parenthas been renamed tomodule_parent. parent is deprecated and will be removed in Rails 6.1. This change is documented here.

This PR resolves this issue for Rails 6+ while maintaining backward compatibility with previous versions.

@alexpeachey alexpeachey merged commit 091aba4 into alexpeachey:master Jan 21, 2020
@alexpeachey
Copy link
Owner

Thank you @danderozier I appreciate the pull request and I'm sorry for the staleness of this gem. I haven't been writing any Ruby for years now but I'm glad to hear this is still of some use.
This change is in the newly released v1.1.0

@danderozier
Copy link
Contributor Author

Thanks! This gem is super useful, and a good time saver. Hope others can continue getting use out of it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants