Prefix Module#parent, Module#parents, and Module#parent_name with module #34051

gmcgibbon · 2018-10-02T17:01:58Z

Summary

Adds module_ prefix to Module#parent, Module#parents, and Module#parent_name.

As discussed in #20901, parents isn't a blacklisted class attribute for model scopes. Using a parents scope will result in a SystemStackError .

An alternate approach would be to disallow parents as a valid scope name, or find a better prefix than module_ because it can include classes which are technically modules but could be better represented.

I'll look into fixing call sites once we decide what the best course of action is.

r? @rafaelfranca

/cc @dhh, @sgrif

dhh · 2018-10-02T17:08:25Z

I like this approach 👍

Prefix Module#parent, Module#parents, and Module#parent_name with module

- Followup of rails#34051

`Module#parent_name is` deprecated in Rails 6.0. Ref: rails/rails#34051

cars10 · 2019-03-04T12:01:03Z

I upgraded my rails 5.2.2 app to 6.0.0.beta2 and every controller actions spams multiple of the following deprecation warnings:

.DEPRECATION WARNING: `Module#parent` has been renamed to `module_parent`. `parent` is deprecated and will be removed in Rails 6.1. (called from block in <class:ApplicationController> at /my/app/app/controllers/application_controller.rb:6)

What is the recommended way to fix these?

kaspth · 2019-03-04T13:32:41Z

@cars10 reading the deprecation message it sounds like you have a parent call on line 6 of your ApplicationController that need to be renamed to module_parent.

cars10 · 2019-03-04T13:35:28Z

I do not have any calls to parent in my entire project. Line 6 in my ApplicationController:

render json: {errors: 'Unauthorized'}, status: 401

Edit: all deprecation warnings point to lines where render is called.
Edit2: i found the cause, active_model_serializers seems to be the cause. see rails-api/active_model_serializers#2316

Suppress DEPRECATION WARNING related this PR. rails/rails#34051

Suppress DEPRECATION WARNING related to [this changes](rails/rails#34051).

`parent_name` will be renamed `module_parent_name` in Rails 6.1, so it displays deprecation warnings on Rails 6.0. refs: rails/rails#34051

Prefix Module#parent, Module#parents, and Module#parent_name with module rails/rails#34051

leastbad · 2019-06-30T17:42:40Z

The marco-polo gem is also impacted by this deprecation. I created a fork that patches the function naming so as to suppress the warnings in console until such time as the upstream is updated.

https://github.com/pjforde1978/marco-polo.git

rails/rails#34051 deprecated .parent in-favor of using .module_parent. This commit updates the code to use the new method, which should remove all of the deprecation warnings we are seeing when using rails v6.

…dule#module_parent` Rails 6 deprecated `Module#parent` and friends in rails/rails#34051, replacing them with a `module_*`-prefix naming scheme. This checks to see if `module_parent` is defined, using it if it's available.

Ref: rails/rails#34051

Since Rails 6.0 the parent method is replaced with module_parent rails/rails#34051

Rails 6 deprecated `Module#parent` and friends in rails/rails#34051, replacing them with a `module_*`-prefix naming scheme. This checks to see if `module_parent` is defined, using it if it's available.

* silence deprecation warning from the rename of `Module#parent` to `Module#module_parent` Rails 6 deprecated `Module#parent` and friends in rails/rails#34051, replacing them with a `module_*`-prefix naming scheme. This checks to see if `module_parent` is defined, using it if it's available. * fix tests with hacky patch * comments * revert formatting changes * Fully support Rails 6.1 in tests * forgot to exclude several old versions of Ruby * fix indentation in blocks Big thanks to @andrew-newell Co-authored-by: Alex Robbin <agrobbin@gmail.com>

It changed in Rails with rails/rails#34051 and the old method has been deprecated and removed. This code should work with both Rails 5.2 and 6.1+

activesupport 6 has breaking change - parent* methods renamed to module_parent*. see rails/rails#34051

`parent` was needed to support Active Model < 6.1. Since the minimum required version is now 7.0, the conditional is not needed anymore Ref: rails/rails#34051 Close #12

Prefix Module#parent, Module#parents, and Module#parent_name with module

004fda3

rails-bot assigned rafaelfranca Oct 2, 2018

rails-bot bot added the activesupport label Oct 2, 2018

rails-bot bot added actionpack activemodel routing labels Oct 2, 2018

gmcgibbon force-pushed the module_parent_method_rename branch from 2f10932 to e013117 Compare October 2, 2018 18:50

rails-bot bot added the activerecord label Oct 2, 2018

Fix call sites

c401c43

gmcgibbon force-pushed the module_parent_method_rename branch from e013117 to c401c43 Compare October 2, 2018 19:36

rails-bot bot added the railties label Oct 2, 2018

gmcgibbon removed actionpack activemodel activerecord railties routing labels Oct 2, 2018

rafaelfranca merged commit c401c43 into rails:master Oct 2, 2018

rafaelfranca added a commit that referenced this pull request Oct 2, 2018

Merge pull request #34051 from gmcgibbon/module_parent_method_rename

92fece9

Prefix Module#parent, Module#parents, and Module#parent_name with module

ruby-bench-server pushed a commit to tgxworld/rails that referenced this pull request Oct 3, 2018

Fix the docs for Module#parents and related methods in guides [ci skip]

92be384

- Followup of rails#34051

gmcgibbon deleted the module_parent_method_rename branch October 5, 2018 20:31

y-yagi added a commit to y-yagi/rollbar-gem that referenced this pull request Jan 25, 2019

Use module_parent_name instead of deprecated parent_name

1ebbe99

`Module#parent_name is` deprecated in Rails 6.0. Ref: rails/rails#34051

y-yagi mentioned this pull request Jan 25, 2019

Use module_parent_name instead of deprecated parent_name rollbar/rollbar-gem#811

Merged

katsuma added a commit to katsuma/garage_client that referenced this pull request Apr 29, 2019

Use Module#module_parent_name for Rails6

a43fa08

Suppress DEPRECATION WARNING related this PR. rails/rails#34051

katsuma added a commit to katsuma/garage_client that referenced this pull request Apr 29, 2019

Use Module#module_parent_name for Rails6

0ce2343

Suppress DEPRECATION WARNING related to [this changes](rails/rails#34051).

katsuma added a commit to katsuma/garage_client that referenced this pull request Apr 29, 2019

Use Module#module_parent_name for Rails6

00cae81

Suppress DEPRECATION WARNING related to [this changes](rails/rails#34051).

katsuma mentioned this pull request Apr 29, 2019

Use Module#module_parent_name for Rails6 cookpad/garage_client#28

Merged

sinsoku added a commit to sinsoku/dd-trace-rb that referenced this pull request May 8, 2019

:warnings: Avoid deprecation warnings on Rails 6

4fef621

`parent_name` will be renamed `module_parent_name` in Rails 6.1, so it displays deprecation warnings on Rails 6.0. refs: rails/rails#34051

sinsoku added a commit to sinsoku/dd-trace-rb that referenced this pull request May 8, 2019

⚠️ Avoid deprecation warnings on Rails 6

2a5dbb6

`parent_name` will be renamed `module_parent_name` in Rails 6.1, so it displays deprecation warnings on Rails 6.0. refs: rails/rails#34051

sinsoku mentioned this pull request May 8, 2019

⚠️ Avoid deprecation warnings on Rails 6 DataDog/dd-trace-rb#750

Merged

suketa added a commit to suketa/rails_sandbox that referenced this pull request Jun 15, 2019

Rails 6.0.0rc1 try038

3b5aab3

Prefix Module#parent, Module#parents, and Module#parent_name with module rails/rails#34051

suketa added a commit to suketa/rails_sandbox that referenced this pull request Jun 16, 2019

Rails 6.0.0rc1 try038

82a02c7

Prefix Module#parent, Module#parents, and Module#parent_name with module rails/rails#34051

9toon mentioned this pull request Aug 22, 2019

Use Module#module_parent_name for Rails6 cookpad/aws-xray#97

Merged

chrismanderson mentioned this pull request Sep 5, 2019

Deprecation warning in Rails 6 stitchfix/stitches#84

Closed

agrobbin mentioned this pull request Sep 23, 2019

Silence deprecation warning from the rename of Module#parent to Module#module_parent voormedia/rails-erd#345

Closed

j-sakamoto mentioned this pull request Dec 17, 2019

Rails6 ttakuru88/devise_google_authenticator#1

Merged

cobafan mentioned this pull request Dec 19, 2019

Use module_parent instead of deprecated parent Compass/compass-rails#279

Closed

danderozier mentioned this pull request Jan 21, 2020

Rails 6.1 compatibility / Fix deprecation warnings in Rails 6.0 alexpeachey/active_null#6

Merged

tatsuyafw mentioned this pull request Feb 1, 2020

Use Module#module_parent_name instead of Module#parent_name rmosolgo/graphql-ruby#2713

Merged

brianp mentioned this pull request Dec 2, 2020

Update Module#parent usage for deprecations dradis/dradis-plugins#41

Merged

rubysamurai added a commit to rubysamurai/meta-rails that referenced this pull request Dec 14, 2020

fix: Use module_parent_name instead of deprecated parent_name

e1e5cb7

Ref: rails/rails#34051

PanosCodes added a commit to PanosCodes/mongoid that referenced this pull request Jan 5, 2021

Replace parent with module_parent_name

ade3d8c

Since Rails 6.0 the parent method is replaced with module_parent rails/rails#34051

PanosCodes mentioned this pull request Jan 5, 2021

Replace parent with module_parent_name mongodb/mongoid#4941

Closed

lxxxvi mentioned this pull request Feb 14, 2021

handle generated value for channel_prefix if app directory contains dots or spaces stimulusreflex/stimulus_reflex#457

Merged

3 tasks

senid231 added a commit to senid231/didww-v3-ruby that referenced this pull request Oct 22, 2021

fix order creation

dc2f2f4

activesupport 6 has breaking change - parent* methods renamed to module_parent*. see rails/rails#34051

senid231 mentioned this pull request Oct 22, 2021

Fix order creation for activesupport 6.X.X didww/didww-v3-ruby#21

Merged

senid231 added a commit to senid231/didww-v3-ruby that referenced this pull request Oct 26, 2021

fix order creation

1cb10f6

activesupport 6 has breaking change - parent* methods renamed to module_parent*. see rails/rails#34051

apfranzen mentioned this pull request May 31, 2022

Rails 6.1 upgrade spreedly/ripple#12

Merged

tagliala mentioned this pull request Jun 15, 2024

Remove AM < 6.1 legacy conditional check ifad/hawk#61

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prefix Module#parent, Module#parents, and Module#parent_name with module #34051

Prefix Module#parent, Module#parents, and Module#parent_name with module #34051

gmcgibbon commented Oct 2, 2018

dhh commented Oct 2, 2018

cars10 commented Mar 4, 2019

kaspth commented Mar 4, 2019 •

edited

Loading

cars10 commented Mar 4, 2019 •

edited

Loading

leastbad commented Jun 30, 2019

Prefix Module#parent, Module#parents, and Module#parent_name with module #34051

Prefix Module#parent, Module#parents, and Module#parent_name with module #34051

Conversation

gmcgibbon commented Oct 2, 2018

Summary

dhh commented Oct 2, 2018

cars10 commented Mar 4, 2019

kaspth commented Mar 4, 2019 • edited Loading

cars10 commented Mar 4, 2019 • edited Loading

leastbad commented Jun 30, 2019

kaspth commented Mar 4, 2019 •

edited

Loading

cars10 commented Mar 4, 2019 •

edited

Loading