Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AM < 6.1 legacy conditional check #61

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

tagliala
Copy link
Member

@tagliala tagliala commented Jun 15, 2024

parent was needed to support Active Model < 6.1.

Since the minimum required version is now 7.0, the conditional is not
needed anymore

Ref: rails/rails#34051

Close #12

`parent` was needed to support Active Model < 6.1.

Since the minimum required version is now 7.0, the conditional is not
needed anymore

Ref: rails/rails#34051

Close #12
@tagliala tagliala force-pushed the chore/12-remove-duplication-of-module-parent branch from 06fe1e4 to 93885eb Compare June 15, 2024 11:19
@tagliala tagliala changed the title Remove legacy conditional check Remove AM < 6.1 legacy conditional check Jun 15, 2024
@tagliala tagliala merged commit 72a9fc2 into master Jun 15, 2024
18 of 19 checks passed
@tagliala tagliala deleted the chore/12-remove-duplication-of-module-parent branch June 15, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplication of module_parent
1 participant