Skip to content

Conversation

@cammonro
Copy link
Contributor

This PR updates our sample module for 3.15.0. I made an effort to organize things a little better and provided demonstrations of:

  • Overriding core libraries now that algoliaBundle has been discontinued
  • Using mixins with Autocomplete
  • Using mixins with InstantSearch
  • Using mixins with core utilities
  • Facet modifications
  • Selecting alternate template engines
  • Stuffing the bundle for backward compatibility with custom hooks that may rely on it (basically just providing a shim for a possible edge case)

Maybe we can release this as a 1.4.0-beta.1 with 3.15.0-beta.2?

Please note that some of the functionality demonstrated here depends on changes introduced in: algolia/algoliasearch-magento-2#1689

@cammonro cammonro requested a review from damcou January 27, 2025 12:49
@cammonro cammonro changed the title Feature/mage 1061 sample mixins MAGE-1061 Sample mixins Jan 27, 2025
Copy link

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work ! 👏 This will help our users to use the hooks for sure (helpful for me as well 😄 )

Maybe we can release this as a 1.4.0-beta.1 with 3.15.0-beta.2?

Since 1.4.0 is linked with the 3.15.x version with the composer file, I think we are fine no ? I'm not a huge fan of adding even more complexity of our release process.

@cammonro
Copy link
Contributor Author

Huge work ! 👏 This will help our users to use the hooks for sure (helpful for me as well 😄 )

Maybe we can release this as a 1.4.0-beta.1 with 3.15.0-beta.2?

Since 1.4.0 is linked with the 3.15.x version with the composer file, I think we are fine no ? I'm not a huge fan of adding even more complexity of our release process.

You're totally right! The dependency covers us here. Let's keep it simple then.

@cammonro cammonro merged commit 0f00c32 into master Jan 28, 2025
@cammonro cammonro deleted the feature/MAGE-1061-sample-mixins branch January 28, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants