-
Notifications
You must be signed in to change notification settings - Fork 4
MAGE-1061 Sample mixins #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…undle MAGE-1002: algoliaBundle removed
…ases Feature/mage 1002 update path aliases
Feature/mage 1015 bundle stuffing
…a InstantSearch configure widget
damcou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge work ! 👏 This will help our users to use the hooks for sure (helpful for me as well 😄 )
Maybe we can release this as a 1.4.0-beta.1 with 3.15.0-beta.2?
Since 1.4.0 is linked with the 3.15.x version with the composer file, I think we are fine no ? I'm not a huge fan of adding even more complexity of our release process.
You're totally right! The dependency covers us here. Let's keep it simple then. |
This PR updates our sample module for 3.15.0. I made an effort to organize things a little better and provided demonstrations of:
algoliaBundlehas been discontinuedMaybe we can release this as a
1.4.0-beta.1with3.15.0-beta.2?Please note that some of the functionality demonstrated here depends on changes introduced in: algolia/algoliasearch-magento-2#1689