This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
chore(dev): replace github dependency metalsmith-in-place #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've checked and the exact npm version (1.4.4) seems to miss 'exposeConsolidate' which we use.
Haroenv
requested review from
yannickcr,
robertmogos,
eunjae-lee,
francoischalifour and
shortcuts
Haroenv
force-pushed
the
chore/metalsmith-in-place
branch
from
7127a6e to
c6f639a
Compare
Haroenv
force-pushed
the
chore/metalsmith-in-place
branch
from
c6f639a to
81f885d
Compare
Haroenv
commented
Oct 30, 2020
| @@ -0,0 +1,24 @@ | |||
| diff --git a/node_modules/metalsmith-in-place/lib/index.js b/node_modules/metalsmith-in-place/lib/index.js | |||
There was a problem hiding this comment.
you can test that this diff is correct by checking https://codeload.github.com/superwolff/metalsmith-in-place/tar.gz/7cb06e54142b8843f35178ceb5560946ae356049 which still exists today
I looked into updating to a newer version of metalsmith-in-place, but they added a bunch of dependencies that seemed hard to migrate towards
|
try this PR out by running |
yannickcr
approved these changes
Oct 30, 2020
Haroenv
added a commit
that referenced
this pull request
Nov 19, 2020
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
…goliasearch-helper-js#796) * chore(dev): replace github dependency metalsmith-in-place I've checked and the exact npm version (1.4.4) seems to miss 'exposeConsolidate' which we use. * patch package for the small change in the github version * add comment
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* chore(dev): replace github dependency metalsmith-in-place (algolia/algoliasearch-helper-js#796) algolia/algoliasearch-helper-js@b277cd6 * feat(ts): fill in more of the types algolia/algoliasearch-helper-js@9a636ec * fix(ts): correct type for getNumericRefinements (algolia/algoliasearch-helper-js#800) algolia/algoliasearch-helper-js@44e16c8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on notification from Indiana Moreau (https://www.securityinnovation.com/)