Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fix(ts): correct type for getNumericRefinements #800

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Nov 18, 2020

this actually returns an object, not an array!

this actually returns an object, not an array!
@Haroenv Haroenv requested a review from a team November 18, 2020 17:21
@ghost ghost requested review from shortcuts and yannickcr and removed request for a team November 18, 2020 17:21
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Haroenv Haroenv merged commit 0920d94 into develop Nov 19, 2020
@Haroenv Haroenv deleted the fix/ts-getNumericRefinements branch November 19, 2020 09:01
Haroenv added a commit that referenced this pull request Nov 19, 2020
 * chore(dev): replace github dependency metalsmith-in-place (#796) 3eb8d39
 * feat(ts): fill in more of the types 34ae5cd
 * fix(ts): correct type for getNumericRefinements (#800) 0920d94
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
 * chore(dev): replace github dependency metalsmith-in-place (algolia/algoliasearch-helper-js#796) algolia/algoliasearch-helper-js@b277cd6
 * feat(ts): fill in more of the types algolia/algoliasearch-helper-js@9a636ec
 * fix(ts): correct type for getNumericRefinements (algolia/algoliasearch-helper-js#800) algolia/algoliasearch-helper-js@44e16c8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants