Skip to content

Commit

Permalink
refactor(js): remove duplicate files (#6493)
Browse files Browse the repository at this point in the history
The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only.

BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
  • Loading branch information
Haroenv committed Dec 30, 2024
1 parent a63c32c commit 77e7914
Show file tree
Hide file tree
Showing 89 changed files with 362 additions and 387 deletions.
5 changes: 1 addition & 4 deletions examples/react/e-commerce/components/PriceSlider.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import {
Range,
RangeBoundaries,
} from 'instantsearch.js/es/connectors/range/connectRange';
import { Range, RangeBoundaries } from 'instantsearch-core';
import React, { useState } from 'react';
import {
Slider,
Expand Down
4 changes: 2 additions & 2 deletions examples/react/e-commerce/components/Ratings.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { connectRatingMenu } from 'instantsearch.js/es/connectors';
import {
RatingMenuConnectorParams,
RatingMenuWidgetDescription,
} from 'instantsearch.js/es/connectors/rating-menu/connectRatingMenu';
} from 'instantsearch-core';
import { connectRatingMenu } from 'instantsearch.js/es/connectors';
import React from 'react';
import { useConnector } from 'react-instantsearch';

Expand Down
2 changes: 1 addition & 1 deletion packages/algolia-experiences/src/banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import { cx } from 'instantsearch-ui-components';
import { h, render } from 'preact';

import type { Banner } from 'algoliasearch-helper';
import type { HitsConnectorParams } from 'instantsearch-core';
import type {
ComponentProps,
HitsClassNames,
} from 'instantsearch-ui-components';
import type { HitsConnectorParams } from 'instantsearch.js/es/connectors/hits/connectHits';

export type BannerWidgetParams = {
container: HTMLElement;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { h } from 'preact';
import { isSpecialClick } from '../../lib/utils';
import Template from '../Template/Template';

import type { BreadcrumbConnectorParamsItem } from '../../connectors/breadcrumb/connectBreadcrumb';
import type { BreadcrumbConnectorParamsItem } from '../../connectors';
import type { PreparedTemplateProps } from '../../lib/templating';
import type { ComponentCSSClasses } from '../../types';
import type {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { h } from 'preact';

import Template from '../Template/Template';

import type { ClearRefinementsRenderState } from '../../connectors/clear-refinements/connectClearRefinements';
import type { ClearRefinementsRenderState } from '../../connectors';
import type { PreparedTemplateProps } from '../../lib/templating';
import type { ComponentCSSClasses } from '../../types';
import type {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { isSpecialClick, capitalize } from '../../lib/utils';
import type {
CurrentRefinementsConnectorParamsItem,
CurrentRefinementsConnectorParamsRefinement,
} from '../../connectors/current-refinements/connectCurrentRefinements';
} from '../../connectors';
import type { ComponentCSSClasses } from '../../types';
import type { CurrentRefinementsCSSClasses } from '../../widgets/current-refinements/current-refinements';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { h } from 'preact';

import Template from '../Template/Template';

import type { MenuRenderState } from '../../connectors/menu/connectMenu';
import type { MenuRenderState } from '../../connectors';
import type { ComponentCSSClasses } from '../../types';
import type {
MenuSelectCSSClasses,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@ import { h, Component } from 'preact';

import Template from '../Template/Template';

import type {
Range,
RangeBoundaries,
} from '../../connectors/range/connectRange';
import type { Range, RangeBoundaries } from '../../connectors';
import type { ComponentCSSClasses } from '../../types';
import type {
RangeInputCSSClasses,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import Template from '../Template/Template';

import RefinementListItem from './RefinementListItem';

import type { HierarchicalMenuItem } from '../../connectors/hierarchical-menu/connectHierarchicalMenu';
import type { HierarchicalMenuItem } from '../../connectors';
import type { PreparedTemplateProps } from '../../lib/templating';
import type { ComponentCSSClasses, CreateURL, Templates } from '../../types';
import type { HierarchicalMenuComponentCSSClasses } from '../../widgets/hierarchical-menu/hierarchical-menu';
Expand Down
2 changes: 1 addition & 1 deletion packages/instantsearch.js/src/components/Slider/Slider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { range } from '../../lib/utils';
import Pit from './Pit';
import Rheostat from './Rheostat';

import type { RangeBoundaries } from '../../connectors/range/connectRange';
import type { RangeBoundaries } from '../../connectors';
import type { ComponentCSSClasses } from '../../types';
import type {
RangeSliderCssClasses,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Template from '../Template/Template';
import type {
ToggleRefinementRenderState,
ToggleRefinementValue,
} from '../../connectors/toggle-refinement/connectToggleRefinement';
} from '../../connectors';
import type { PreparedTemplateProps } from '../../lib/templating';
import type { ComponentCSSClasses } from '../../types';
import type {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { h } from 'preact';

import Template from '../Template/Template';

import type { VoiceListeningState } from '../../connectors/voice-search/connectVoiceSearch';
import type { VoiceListeningState } from '../../connectors';
import type { ComponentCSSClasses } from '../../types';
import type {
VoiceSearchCSSClasses,
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

7 changes: 0 additions & 7 deletions packages/instantsearch.js/src/connectors/hits/connectHits.ts

This file was deleted.

Loading

0 comments on commit 77e7914

Please sign in to comment.