refactor(js): remove duplicate files #6493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 93512e3:
|
Haroenv
force-pushed
the
refactor/remove-duplicate-files
branch
2 times, most recently
from
cb941e5 to
4ba4556
Compare
Haroenv
force-pushed
the
refactor/remove-duplicate-files
branch
from
4ba4556 to
a81d241
Compare
The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only.
BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
force-pushed
the
refactor/remove-duplicate-files
branch
from
a81d241 to
a26e97f
Compare
aymeric-giraudet
approved these changes
Dec 30, 2024
Haroenv
added a commit
that referenced
this pull request
Jan 9, 2025
The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only.
BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only.
BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only.
BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only.
BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Jan 17, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Jan 22, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Jan 22, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Jan 27, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Jan 28, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Feb 17, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Feb 18, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Haroenv
pushed a commit
that referenced
this pull request
Feb 18, 2025
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> refactor(react): replace instantsearch.js with instantsearch-core (#6439) BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication refactor(vue): replace instantsearch.js with instantsearch-core (#6440) [FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication feat(core): migrate instantsearch.js to instantsearch-core (#6424) BREAKING CHANGE: __hitIndex is no longer populated refactor(js): remove duplicate files (#6493) The files `connectors/*/connect*.ts` and `middlewares/create*Middleware.ts` files have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only. BREAKING CHANGE: import only from `instantsearch.js/es/{connectors,middleware}` or `instantsearch-core`, not from no longer existing child files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files
connectors/*/connect*.tsandmiddlewares/create*Middleware.tsfiles have the same name in instantsearch.js as in instantsearch-core, making file navigation annoying. This is now solved by re-exporting in the barrel file for those files only.BREAKING CHANGE: import only from
instantsearch.js/es/{connectors,middleware}orinstantsearch-core, not from no longer existing child files