fix(analytics): generate fallback userToken #5500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(insights): automatically load search-insights if not passed FX-2244 * different wording * fix(insights): notify of error when insights fails to load * prettier snippet
To better prepare for the insights middleware being automatically added, we are making the following changes: - useCookie by default true so userToken does not need to be provided - still call `insightsClient` if no userToken is found (userToken can be applied using useCookie, thus not known) - error on unknown algolia credentials converted to warning
FX-2250 Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f107a67:
|
Haroenv
commented
Feb 27, 2023
| }, | ||
| }); | ||
| search.use(insights); | ||
| // const insights = instantsearch.middlewares.createInsightsMiddleware({ |
Haroenv
added a commit
that referenced
this pull request
Feb 27, 2023
This makes sure when the same userToken is set multiple times, it doesn't cause multiple search requests, as could be the case if something would call setUserToken without condition. Discovered in #5500, but should be merged separately.
Haroenv
added a commit
that referenced
this pull request
Feb 28, 2023
This makes sure when the same userToken is set multiple times, it doesn't cause multiple search requests, as could be the case if something would call setUserToken without condition. Discovered in #5500, but should be merged separately. Co-authored-by: Fabien Motte <fabien.motte@algolia.com>
Haroenv
force-pushed
the
feat/automatic-insights
branch
from
ad20519 to
b6ef7b3
Compare
Haroenv
added a commit
that referenced
this pull request
Mar 2, 2023
This makes sure when the same userToken is set multiple times, it doesn't cause multiple search requests, as could be the case if something would call setUserToken without condition. Discovered in #5500, but should be merged separately. Co-authored-by: Fabien Motte <fabien.motte@algolia.com>
Haroenv
added a commit
that referenced
this pull request
Mar 2, 2023
This makes sure when the same userToken is set multiple times, it doesn't cause multiple search requests, as could be the case if something would call setUserToken without condition. Discovered in #5500, but should be merged separately. Co-authored-by: Fabien Motte <fabien.motte@algolia.com>
Haroenv
force-pushed
the
feat/automatic-insights
branch
from
b6ef7b3 to
00568aa
Compare
Haroenv
added a commit
that referenced
this pull request
Mar 8, 2023
This makes sure when the same userToken is set multiple times, it doesn't cause multiple search requests, as could be the case if something would call setUserToken without condition. Discovered in #5500, but should be merged separately. Co-authored-by: Fabien Motte <fabien.motte@algolia.com>
Haroenv
force-pushed
the
feat/automatic-insights
branch
from
b4e9504 to
7f415a8
Compare
|
With the RFC on decoupling (or using v3) we'll likely not need this. Should we close @Haroenv? |
Haroenv
added a commit
that referenced
this pull request
Apr 18, 2023
This makes sure when the same userToken is set multiple times, it doesn't cause multiple search requests, as could be the case if something would call setUserToken without condition. Discovered in #5500, but should be merged separately. Co-authored-by: Fabien Motte <fabien.motte@algolia.com>
Haroenv
added a commit
that referenced
this pull request
Apr 24, 2023
This makes sure when the same userToken is set multiple times, it doesn't cause multiple search requests, as could be the case if something would call setUserToken without condition. Discovered in #5500, but should be merged separately. Co-authored-by: Fabien Motte <fabien.motte@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Result