fix(ssr): allow getWidgetState to be empty for createURL (#805)

* fix(ssr): allow getWidgetState to be empty for createURL This must have been caused by a wrong copy-paste * test(ssr): add case for createURL
algolia · Jun 18, 2020 · 0528b55 · 0528b55
1 parent 6ee1404
commit 0528b55
Show file tree

Hide file tree

Showing 2 changed files with 66 additions and 23 deletions.
diff --git a/src/util/__tests__/createServerRootMixin.test.js b/src/util/__tests__/createServerRootMixin.test.js
@@ -433,35 +433,78 @@ Object {
       );
     });
 
-    it('has a fake createURL', () => {
-      const app = new Vue({
-        mixins: [
-          createServerRootMixin({
-            searchClient: createFakeClient(),
-            indexName: 'lol',
-          }),
-        ],
-      });
+    describe('createURL', () => {
+      it('returns # if instantsearch has no routing', () => {
+        const app = new Vue({
+          mixins: [
+            createServerRootMixin({
+              searchClient: createFakeClient(),
+              indexName: 'lol',
+            }),
+          ],
+        });
 
-      const widget = {
-        init: jest.fn(),
-        render: jest.fn(),
-      };
+        const widget = {
+          init: jest.fn(),
+          render: jest.fn(),
+        };
 
-      const instantSearchInstance = app.$data.instantsearch;
+        const instantSearchInstance = app.$data.instantsearch;
 
-      instantSearchInstance.hydrate({
-        lol: createSerializedState(),
+        instantSearchInstance.hydrate({
+          lol: createSerializedState(),
+        });
+
+        instantSearchInstance.__forceRender(
+          widget,
+          instantSearchInstance.mainIndex
+        );
+
+        const renderArgs = widget.render.mock.calls[0][0];
+
+        expect(renderArgs.createURL()).toBe('#');
       });
 
-      instantSearchInstance.__forceRender(
-        widget,
-        instantSearchInstance.mainIndex
-      );
+      it('allows for widgets without getWidgetState', () => {
+        const app = new Vue({
+          mixins: [
+            createServerRootMixin({
+              searchClient: createFakeClient(),
+              indexName: 'lol',
+            }),
+          ],
+        });
+
+        const widget = {
+          init: jest.fn(),
+          render: jest.fn(),
+          getWidgetState(uiState) {
+            return uiState;
+          },
+        };
 
-      const renderArgs = widget.render.mock.calls[0][0];
+        const widgetWithoutGetWidgetState = {
+          init: jest.fn(),
+          render: jest.fn(),
+        };
+
+        const instantSearchInstance = app.$data.instantsearch;
+
+        instantSearchInstance.hydrate({
+          lol: createSerializedState(),
+        });
 
-      expect(renderArgs.createURL()).toBe('#');
+        instantSearchInstance.addWidgets([widget, widgetWithoutGetWidgetState]);
+
+        instantSearchInstance.__forceRender(
+          widget,
+          instantSearchInstance.mainIndex
+        );
+
+        const renderArgs = widget.render.mock.calls[0][0];
+
+        expect(renderArgs.createURL()).toBe('#');
+      });
     });
   });
 });
diff --git a/src/util/createServerRootMixin.js b/src/util/createServerRootMixin.js
@@ -167,7 +167,7 @@ function augmentInstantSearch(instantSearchOptions, searchClient, indexName) {
           .getWidgets()
           .filter(w => w.$$type !== 'ais.index')
           .reduce((uiState, w) => {
-            if (!widget.getWidgetState) {
+            if (!w.getWidgetState) {
               return uiState;
             }