This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(ssr): allow getWidgetState to be empty for createURL #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This must have been caused by a wrong copy-paste
yannickcr
approved these changes
Jun 18, 2020
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…-instantsearch#805) * fix(ssr): allow getWidgetState to be empty for createURL This must have been caused by a wrong copy-paste * test(ssr): add case for createURL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check was on the widget itself, instead of on the current iteration.
See this for original code which didn't have the issue:
https://github.com/algolia/instantsearch.js/blob/ada37ae054275d46cc2edaee0081562b6c35cbc8/src/widgets/index/index.ts#L101-L115