Code changes #2
Merged
Code changes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangsu
approved these changes
Aug 9, 2022
|
Yes, I have a draft PR in go-algorand that does that algorand/go-algorand#4375 |
michaeldiamant
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
@jasonpaulos Changes seem reasonable. Thanks for adding abi/doc.go! I'll aim to be more mindful of package-level docs.
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
jasonpaulos
added a commit
that referenced
this pull request
Aug 10, 2022
* Add initial code * Downgrade testify to match go-algorand's version (#3) * Use `avm_abi` package name * Revert "Use `avm_abi` package name" This reverts commit 10a0279. * Rename directory to abi * Add `golangci-lint` (#4) * Add golangci-lint * Checkout code first * Lint tests * Code changes (#2) * Make all txn types into variables * Remove ParseArgJSONtoByteSlice * Use '%w' for errors * Remove no longer relevent comment * Test VerifyMethodSignature * Add documentation * Make readme match docs * Update docs package * Update abi/doc.go Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Child PR to #1
This PR contains code changes not present in the original go-algorand code, but that I think make sense in this standalone repo. The commit log contains one commit per "category" of change.
The largest change is removing
ParseArgJSONtoByteSlice, which is responsible for parsing method arguments from JSON and encoding them into app call byte arrays. In it's current form, I think this function is too specialized to be in avm-abi, and there are a lot of undocumented assumptions about the inputs and outputs. I've decided to delete the function from this repo and instead move it to the one place it's used, in go-algorand'scmd/goal/application.go.