Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Use avm-abi repo #4375

Merged
merged 7 commits into from
Aug 16, 2022
Merged

Conversation

jasonpaulos
Copy link
Contributor

@jasonpaulos jasonpaulos commented Aug 8, 2022

Summary

This PR removes the ABI type code from this repo and replaces it with the new avm-abi repo.

Test Plan

Relevant tests moved to new repo.

@jasonpaulos jasonpaulos changed the title Use avm-abi repo AVM: Use avm-abi repo Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #4375 (02de158) into master (fd488f8) will decrease coverage by 0.16%.
The diff coverage is 55.17%.

@@            Coverage Diff             @@
##           master    #4375      +/-   ##
==========================================
- Coverage   55.34%   55.17%   -0.17%     
==========================================
  Files         400      397       -3     
  Lines       50797    50073     -724     
==========================================
- Hits        28112    27627     -485     
+ Misses      20311    20150     -161     
+ Partials     2374     2296      -78     
Impacted Files Coverage Δ
data/basics/address.go 90.32% <ø> (ø)
data/transactions/logic/assembler.go 85.12% <ø> (ø)
cmd/goal/application.go 12.78% <55.17%> (+1.61%) ⬆️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
util/db/dbutil.go 44.24% <0.00%> (-4.25%) ⬇️
network/wsPeer.go 65.47% <0.00%> (-2.20%) ⬇️
ledger/tracker.go 73.93% <0.00%> (-0.86%) ⬇️
network/wsNetwork.go 65.93% <0.00%> (+1.04%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
ledger/blockqueue.go 88.50% <0.00%> (+1.14%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasonpaulos jasonpaulos marked this pull request as ready for review August 15, 2022 20:39
@michaeldiamant michaeldiamant merged commit f156f69 into algorand:master Aug 16, 2022
@jasonpaulos jasonpaulos deleted the use-avm-abi branch August 16, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants