Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning spam: "http block fetcher response status code : 400" #12

Closed
winder opened this issue Jun 13, 2019 · 1 comment
Closed

Fix warning spam: "http block fetcher response status code : 400" #12

winder opened this issue Jun 13, 2019 · 1 comment

Comments

@winder
Copy link
Contributor

winder commented Jun 13, 2019

Noticed these warnings in the logs at a rate of about 3/second. We probably don't need to keep making requests when the status is 400

{"file":"fetcher.go","function":"github.com/algorand/go-algorand/rpcs.(*NetworkFetcher).FetchBlock","level":"info","line":221,"msg":"networkFetcher.FetchBlock: asking client xxxx:4161 for block 237179","time":"2019-06-13T15:28:08.423330Z"}
{"file":"httpFetcher.go","function":"github.com/algorand/go-algorand/rpcs.(*HTTPFetcher).GetBlockBytes","level":"warning","line":88,"msg":"http block fetcher response status code : 400","time":"2019-06-13T15:28:08.451490Z"}
@tsachiherman
Copy link
Contributor

It's true that we should make requests that would return 400 ( i.e. BadRequest ). But more important is to understand the reason we received 400, which isn't returned and logged.
I'd suggest adding to the HTTP response either a header or a body content that would allow us to communicate the reason for which this is a "bad" request. Then, we should log the reason along with the returned error.
That would give us visibility for the best fix for the problem.

@Vervious Vervious modified the milestones: Backlog, Consensus Backlog Jul 11, 2019
derbear pushed a commit to derbear/go-algorand that referenced this issue Oct 7, 2019
pzbitskiy pushed a commit to pzbitskiy/go-algorand that referenced this issue Mar 17, 2020
reimplement TEAL string ops: concat, substring, substring3
barnjamin referenced this issue in barnjamin/go-algorand Sep 15, 2022
jannotti added a commit to algoidurovic/go-algorand that referenced this issue Sep 16, 2022
…_pr_review

Feedback on #3 for switchi fall-through
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants