Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: skip db concurrent Read/Write tests if test.short is set #4533

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

id-ms
Copy link
Contributor

@id-ms id-ms commented Sep 12, 2022

Summary

Some of the dbutil tests run for a long time and simulate some specific edge cases on the databases infrastructure. it is safe to run those tests only on nightly jobs.

Test Plan

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #4533 (6053a20) into master (794a63d) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4533      +/-   ##
==========================================
- Coverage   54.08%   54.03%   -0.05%     
==========================================
  Files         401      401              
  Lines       51542    51542              
==========================================
- Hits        27876    27852      -24     
- Misses      21332    21357      +25     
+ Partials     2334     2333       -1     
Impacted Files Coverage Δ
network/phonebook.go 83.49% <0.00%> (-5.83%) ⬇️
util/db/dbutil.go 43.63% <0.00%> (-4.85%) ⬇️
ledger/tracker.go 74.89% <0.00%> (-3.83%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
catchup/service.go 68.14% <0.00%> (-1.24%) ⬇️
network/wsNetwork.go 64.82% <0.00%> (-1.05%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/acctupdates.go 70.19% <0.00%> (+0.59%) ⬆️
network/requestTracker.go 71.98% <0.00%> (+0.86%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@id-ms id-ms changed the title Tests: skip reading while writing db tests Tests: skip db concurrent Read/Write tests if test.short is set Sep 12, 2022
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Michael's comment, it is better to have the skipping reason right there

@algorandskiy algorandskiy merged commit 54393ba into algorand:master Sep 23, 2022
@id-ms id-ms deleted the skip-long-db-tests branch September 23, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants