Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: skip db concurrent Read/Write tests if test.short is set #4533

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Tests: skip db concurrent Read/Write tests if test.short is set #4533

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e8c610
skip reading while writing tests if short flag is set
Sep 12, 2022
6053a20
explaining the reason for skipping the db tests
Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions util/db/dbutil_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,9 @@ func cleanupSqliteDb(t *testing.T, path string) {

func TestDBConcurrencyRW(t *testing.T) {
partitiontest.PartitionTest(t)
if testing.Short() {
t.Skip()
}

dbFolder := "/dev/shm"
os := runtime.GOOS
Expand Down Expand Up @@ -492,6 +495,10 @@ func testLockingTableWhileWriting(t *testing.T, useWAL bool) {
partitiontest.PartitionTest(t)
a := require.New(t)

if testing.Short() {
t.Skip()
}

dbParams := []string{"_secure_delete=on"} // not required but used in ErasableAccessor, so I'd like it to be tested here as well
if useWAL {
dbParams = []string{"_secure_delete=on", "_journal_mode=wal"}
Expand Down