Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: go-algorand relstable3.18.1-remerge mergeback #5770

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

onetechnical
Copy link
Contributor

@onetechnical onetechnical commented Oct 3, 2023

relstable3.18.1-remerge

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #5770 (9487d3b) into master (79fb8fe) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #5770      +/-   ##
==========================================
- Coverage   55.50%   55.46%   -0.04%     
==========================================
  Files         473      473              
  Lines       66684    66688       +4     
==========================================
- Hits        37010    36988      -22     
- Misses      27156    27184      +28     
+ Partials     2518     2516       -2     
Files Coverage Δ
data/basics/units.go 55.10% <25.00%> (-4.90%) ⬇️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jasonpaulos
jasonpaulos previously approved these changes Oct 3, 2023
@jasonpaulos jasonpaulos dismissed their stale review October 3, 2023 18:05

Actually, seems like codegen verification is expecting the old msgp code...

@ohill ohill force-pushed the relstable3.18.1-remerge branch from 051b396 to 422abcc Compare October 3, 2023 19:10
@ohill ohill force-pushed the relstable3.18.1-remerge branch from 422abcc to 802955b Compare October 3, 2023 19:20
@algojohnlee algojohnlee merged commit d479850 into master Oct 3, 2023
@algojohnlee algojohnlee deleted the relstable3.18.1-remerge branch October 3, 2023 19:55
@onetechnical onetechnical restored the relstable3.18.1-remerge branch October 4, 2023 14:13
@onetechnical onetechnical deleted the relstable3.18.1-remerge branch July 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants