Ops: Bump ubuntu and centos versions for building and testing #6378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting against Fedora 41 and 42. Drop config support for CircleCI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6378 +/- ##
==========================================
- Coverage 50.62% 50.44% -0.19%
==========================================
Files 660 653 -7
Lines 110513 110415 -98
==========================================
- Hits 55952 55696 -256
- Misses 51704 51856 +152
- Partials 2857 2863 +6 ☔ View full report in Codecov by Sentry. |
onetechnical
requested changes
Jul 14, 2025
Contributor
onetechnical
left a comment
onetechnical
left a comment
There was a problem hiding this comment.
Only the update.sh change is requested; the other change is a small nit.
I'll think on testing for this PR as well.
onetechnical
requested changes
Jul 14, 2025
Contributor
onetechnical
left a comment
onetechnical
left a comment
There was a problem hiding this comment.
We need to remove epel-next-release from the centos dockerfiles, because it doesn't seem to exist for centos10.
Co-authored-by: John Lee <john@onetechnical.com>
Co-authored-by: John Lee <john@onetechnical.com>
onetechnical
previously approved these changes
Jul 14, 2025
algorandskiy
changed the title
algorandskiy
previously approved these changes
Jul 15, 2025
In algorand#6378 the Makefile was refactored to use the preferred GOBIN variable. However, this broke mac universal builds. This PR revises the build to skip over NONGO_BIN files and handle node exporter separately.
onetechnical
approved these changes
Jul 15, 2025
algorandskiy
approved these changes
Jul 15, 2025
This was referenced Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump ubuntu and centos versions for building and testing. Support testing against Fedora 41 and 42. Drop config support for CircleCI.
Test Plan
Existing tests should pass; we'll need to adjust where needed during release prep.