-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API: Add algod block hash endpoint, add indexer block header-only param. #665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good to me. We should base the changes in the harness script off the definitive version of it in algorand/go-algorand-sdk#421
I'm not sure why formatting fails, the new code has been formatted with https://prettier.io/playground/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the understanding that tests should pass before merging. I also recommend someone more experienced in Javascript have a look.
REST API changes and test implementations.
Tests are passing locally, CI is pending algorand/algorand-sdk-testing#245