Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API: Add algod block hash endpoint, add indexer block header-only param. #665

Merged
merged 7 commits into from
Oct 7, 2022

Conversation

winder
Copy link
Contributor

@winder winder commented Oct 5, 2022

REST API changes and test implementations.

Tests are passing locally, CI is pending algorand/algorand-sdk-testing#245

Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me. We should base the changes in the harness script off the definitive version of it in algorand/go-algorand-sdk#421

@winder winder changed the title Update client, add tests REST API: Add algod block hash endpoint, add indexer block header-only param. Oct 6, 2022
@winder
Copy link
Contributor Author

winder commented Oct 7, 2022

I'm not sure why formatting fails, the new code has been formatted with https://prettier.io/playground/

@winder winder requested a review from tzaffi October 7, 2022 14:51
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the understanding that tests should pass before merging. I also recommend someone more experienced in Javascript have a look.

@barnjamin
Copy link
Contributor

@winder i pr'd a fmt tweak that made the linter happy in #667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants