Proposing API minor change on ABIReturnSubroutine for name overriding
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ben proposed a PR for
ABIReturnSubroutinename overriding in #550 , which is assumed to be suggested by algorandfoundation/beaker#84.The bug fix change in #550 looks good, but it also suggest that we are explicitly passing override name in both
method_signatureandmethod_specmethods, and it doesn't smell good.I propose a small API change, such that one can specify the override name on construction for
ABIReturnSubroutine.We should probably ignore
overriding_nameargument inmethod_signature, but I haven't thought through how that method should change.