Feature/method overriding #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2022
|
Just an update, waiting for tagged release of Pyteal before merging this |
|
Are there any changes needed for this PR to leverage the tagged changes to PyTeal? |
|
I think it should be a lot easier by just passing the name override if set to the ABIReturnSubroutine init here: https://github.com/algorand-devrel/beaker/pull/84/files#diff-1f148113406f6c8d6467fc7964353aa258d559bf13f2373601e39913bf042e29L462 arg: https://github.com/algorand/pyteal/blob/master/pyteal/ast/subroutine.py#L525 |
|
This PR is currently relying on features from a specific PyTeal commit that hasn't been released yet into a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.