-
-
Notifications
You must be signed in to change notification settings - Fork 359
insertion-sort-chapter #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,54 @@ | |||
# Insertion Sort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file sorting_searching.md
seems to be a copy of insertion_sort.md
, is there a reason for the two files?
Hey @GuyPozner Thanks for the submission and for writing the insertion sort chapter! I would like to use this PR as a test-case to see how the submission of chapter text can work, so give me a little while to do a review and some digging on my side. In general, I try to let my own chapter PR's stay up for about a week for comments and such from the community, so expect a similar timeframe here. The chapter looks fine at first glance, and insertion sort doesn't build into too many algorithms (that I know of), so it's a good algorithm to test chapter submissions with. That said, I might be a little harsh on the text at places and ask for a lot more detail in certain areas. |
Any updates here? |
Unfortunately not. I haven't had the time to study insertion sort, but should have time this weekend. We are still kinda new to the text-reviewing, so I have a few chapters I need to look at. I am sorry it's taking so long! Thanks for finishing the py monte carlo stuff, by the way. |
[lang: c] |
[lang: python] |
@leios Do we still want to have this PR open, since we removed the sorting chapters from the AAA? We could still re-open it later, when we decide to add them again |
I'm actually not sure what to do with this PR. I think I am happy to add sorting and searching chapters, so long as they are community-contributed. That means this PR is still on the table if @GuyPozner is still willing to help with it (after taking a few years to get back to them) |
Hi, Ive created an insertion sort chapter, hope you'll like it. I'll add more languages soon.