Skip to content

added selection sort python algorithme #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

added selection sort python algorithme #217

wants to merge 3 commits into from

Conversation

srvmux
Copy link
Contributor

@srvmux srvmux commented Jul 4, 2018

No description provided.

@srvmux srvmux changed the title added insertion sort python algorithme added selection sort python algorithme Jul 4, 2018
@Gathros Gathros added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) On Hold This is on hold. labels Jul 4, 2018
@Gathros
Copy link
Contributor

Gathros commented Jul 4, 2018

I'm putting this on hold till #216 gets the green light.

@srvmux
Copy link
Contributor Author

srvmux commented Jul 4, 2018

this is not insertion sort sorry, this is selection sort I've corrected it.

@Gathros Gathros removed the On Hold This is on hold. label Jul 4, 2018
@Gathros
Copy link
Contributor

Gathros commented Jul 4, 2018

I got rid of the on hold label since it's not the same algorithm.

@june128
Copy link
Member

june128 commented Jul 4, 2018

The algorithm will not be in the AAA soon and in general algorithms should be written with the chapter in mind imho. Also they need to get integrated in the chapter and if there is no chapter, the algorithm can't be integrated. I see no reason, why this PR even exists.
I appreciate the contribution tho! We're trying to build out the AAA as fast as possible while holding up with our quality standards.

@srvmux srvmux closed this Jul 4, 2018
@srvmux srvmux deleted the patch-1 branch July 4, 2018 20:16
jiegillet
jiegillet reviewed Jul 5, 2018
View reviewed changes
chapters/sorting_searching/selection/code/python/selection.py
@@ -0,0 +1,7 @@
def selectionList(lst):
for i in range(0, len(lst)):
if i < len(lst):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this if statement is doing. Could you please explain?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really can't remember what was the purpose of that, and it seems wrong from looking at it now, I'm ashamed of this tbh, I code better than this now I promise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegillet jiegillet jiegillet left review comments

Assignees
No one assigned
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srvmux @Gathros @june128 @jiegillet