Handle Kafka API_VERSIONS request #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wuchong this PR is finished, PTAL |
wuchong
reviewed
Mar 11, 2025
fluss-kafka/src/test/java/com/alibaba/fluss/kafka/KafkaRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
| .setMinVersion(apiKey.oldestVersion()) | ||
| .setMaxVersion(apiKey.latestVersion()); | ||
| if (apiKey.equals(ApiKeys.METADATA)) { | ||
| // Not support TopicId |
There was a problem hiding this comment.
Fluss uses tableId, a globally unique identifier of type long, to represent a table. Would it be feasible to use tableId as the topicId for Kafka in the future? For instance, by converting the long value into the leastSignificantBits and using a constant value for the mostSignificantBits.
There was a problem hiding this comment.
Support topic id will make it more complex, we have to handle the case of topic ids is not empty and topic names not empty.
But we can support it in the future, at the current stage, make it as easier as we can.
fluss-kafka/src/test/java/com/alibaba/fluss/kafka/KafkaRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
fluss-kafka/src/test/java/com/alibaba/fluss/kafka/KafkaRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
fluss-kafka/src/test/java/com/alibaba/fluss/kafka/KafkaRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #545
Handle Kafka API_VERSIONS request
Brief change log
Tests
Tests completed
API and Format
Documentation