-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Kafka API_VERSIONS request #547
Open
dao-jun
wants to merge
4
commits into
alibaba:main
Choose a base branch
from
dao-jun:kafka/handle_API_VERSIONS
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
fluss-kafka/src/test/java/com/alibaba/fluss/kafka/KafkaRequestHandlerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /* | ||
| * Copyright (c) 2024 Alibaba Group Holding Ltd. | ||
dao-jun marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.alibaba.fluss.kafka; | ||
|
|
||
| import com.alibaba.fluss.shaded.netty4.io.netty.buffer.ByteBuf; | ||
| import com.alibaba.fluss.shaded.netty4.io.netty.buffer.ByteBufAllocator; | ||
| import com.alibaba.fluss.shaded.netty4.io.netty.channel.ChannelHandlerContext; | ||
|
|
||
| import org.apache.kafka.common.protocol.ApiKeys; | ||
| import org.apache.kafka.common.protocol.Errors; | ||
| import org.apache.kafka.common.requests.AbstractResponse; | ||
| import org.apache.kafka.common.requests.ApiVersionsRequest; | ||
| import org.apache.kafka.common.requests.ApiVersionsResponse; | ||
| import org.apache.kafka.common.requests.RequestHeader; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Mockito; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.concurrent.CompletableFuture; | ||
|
|
||
| public class KafkaRequestHandlerTest { | ||
|
|
||
| @Test | ||
| public void testKafkaApiVersionsNotSupported() { | ||
| KafkaRequestHandler handler = new KafkaRequestHandler(); | ||
| short latestVersion = ApiKeys.API_VERSIONS.latestVersion(); | ||
| ApiVersionsRequest apiVersionsRequest = | ||
| new ApiVersionsRequest.Builder().build(latestVersion); | ||
| ChannelHandlerContext ctx = Mockito.mock(ChannelHandlerContext.class); | ||
| Mockito.doReturn(ByteBufAllocator.DEFAULT).when(ctx).alloc(); | ||
dao-jun marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| KafkaRequest request = | ||
| new KafkaRequest( | ||
| ApiKeys.API_VERSIONS, | ||
| (short) (latestVersion + 1), // unsupported version | ||
| new RequestHeader(ApiKeys.API_VERSIONS, latestVersion, "client-id", 0), | ||
| apiVersionsRequest, | ||
| ByteBufAllocator.DEFAULT.buffer(), | ||
| ctx, | ||
| new CompletableFuture<>()); | ||
| handler.handleApiVersionsRequest(request); | ||
|
|
||
| ByteBuf responseBuffer = request.serialize(); | ||
| ApiVersionsResponse response = | ||
| (ApiVersionsResponse) | ||
| AbstractResponse.parseResponse( | ||
| responseBuffer.nioBuffer(), request.header()); | ||
| Map<Errors, Integer> errorCounts = response.errorCounts(); | ||
| Assertions.assertEquals(1, errorCounts.size()); | ||
| Assertions.assertEquals(1, errorCounts.get(Errors.UNSUPPORTED_VERSION)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testKafkaApiVersionsRequest() { | ||
| KafkaRequestHandler handler = new KafkaRequestHandler(); | ||
| short latestVersion = ApiKeys.API_VERSIONS.latestVersion(); | ||
| ApiVersionsRequest apiVersionsRequest = | ||
| new ApiVersionsRequest.Builder().build(latestVersion); | ||
| ChannelHandlerContext ctx = Mockito.mock(ChannelHandlerContext.class); | ||
| Mockito.doReturn(ByteBufAllocator.DEFAULT).when(ctx).alloc(); | ||
| KafkaRequest request = | ||
| new KafkaRequest( | ||
| ApiKeys.API_VERSIONS, | ||
| latestVersion, | ||
| new RequestHeader(ApiKeys.API_VERSIONS, latestVersion, "client-id", 0), | ||
| apiVersionsRequest, | ||
| ByteBufAllocator.DEFAULT.buffer(), | ||
| ctx, | ||
| new CompletableFuture<>()); | ||
| handler.handleApiVersionsRequest(request); | ||
|
|
||
| ByteBuf responseBuffer = request.serialize(); | ||
| ApiVersionsResponse response = | ||
| (ApiVersionsResponse) | ||
| AbstractResponse.parseResponse( | ||
| responseBuffer.nioBuffer(), request.header()); | ||
| Map<Errors, Integer> errorCounts = response.errorCounts(); | ||
| Assertions.assertEquals(1, errorCounts.size()); | ||
| Assertions.assertEquals(1, errorCounts.get(Errors.NONE)); | ||
dao-jun marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| response.data() | ||
| .apiKeys() | ||
| .forEach( | ||
| apiVersion -> { | ||
| if (ApiKeys.METADATA.id == apiVersion.apiKey()) { | ||
| Assertions.assertTrue((short) 11 >= apiVersion.maxVersion()); | ||
| } else if (ApiKeys.FETCH.id == apiVersion.apiKey()) { | ||
| Assertions.assertTrue((short) 12 >= apiVersion.maxVersion()); | ||
| } else { | ||
| Assertions.assertEquals( | ||
| apiVersion.minVersion(), apiVersion.minVersion()); | ||
| Assertions.assertEquals( | ||
| apiVersion.maxVersion(), apiVersion.maxVersion()); | ||
dao-jun marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| }); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fluss uses
tableId, a globally unique identifier of typelong, to represent a table. Would it be feasible to usetableIdas thetopicIdfor Kafka in the future? For instance, by converting thelongvalue into theleastSignificantBitsand using a constant value for themostSignificantBits.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support topic id will make it more complex, we have to handle the case of topic ids is not empty and topic names not empty.
But we can support it in the future, at the current stage, make it as easier as we can.