-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotifx: store is undefined in class component #3579
Merged
chenbin92
merged 5 commits into
release-next
from
hotifx/store-in-class-component-undefined
Sep 25, 2020
Merged
Hotifx: store is undefined in class component #3579
chenbin92
merged 5 commits into
release-next
from
hotifx/store-in-class-component-undefined
Sep 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenbin92
reviewed
Sep 25, 2020
|
||
<% if(hasPageStore) { %> | ||
<%- pageStoreImport %> | ||
<% } %> | ||
|
||
<%- pageComponentImport %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在这样有循环依赖问题。单独生成 PageName.tsx 文件,然后 index.ts 只负责导出 store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
SoloJiang
approved these changes
Sep 25, 2020
chenbin92
approved these changes
Sep 25, 2020
改下版本 |
chenbin92
approved these changes
Sep 25, 2020
chenbin92
approved these changes
Sep 25, 2020
chenbin92
approved these changes
Sep 25, 2020
ClarkXia
added a commit
that referenced
this pull request
Sep 28, 2020
* chore: bump version * fix: catch debug webpackConfig error (#3541) * fix: catch debug webpackConfig error * fix: serializing object that contains cyclic object value * chore: code optimize (#3549) * chore: code optimize * chore: bump version * feat: support px2vw (#3546) * feat: support px2vw * docs: changelog.md update * docs: package.json update * docs: fusion.md add usePx2Vw option * fix: remove use postcss-loader * fix: ignore rules (#3544) * docs: test guide (#3545) * chore: bump version * chore: bump version * hotifx: store is undefined in class component (#3579) * feat: support rax ssr * chore: rename plugin ssr * feat: support set the SSR in the build.json * chore: reset code * chore: bump version * fix: eslint warnings (#3543) * feat: call the getInitialData method of appConfig * feat: support mode mpa of rax-app (#3575) * feat: support mpa plugin * fix: build-mpa-config * fix: remove mpa-loader * fix: entry error * fix: ts config * feat: support mpa ssr * feat: support mpa loader (#3594) * fix: update react-refresh-webpack-plugin version (#3558) * feat: support set html in mpa mode (#3566) * feat: support set html in mpa mode * chore: update mpa example * chore: code optimize * chore: code optimize * chore: update example * chore: optional staticConfig * fix: mpa loader in node env * fix: command args * fix: support weex mpa * refactor: rename packages * chore: dependency * chore: code optimize Co-authored-by: Yurisa <779509411@qq.com> Co-authored-by: Hengchang Lu <44047106+luhc228@users.noreply.github.com> Co-authored-by: ClarkXia <xiawenwu41@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: #3559