Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotifx: store is undefined in class component #3579

Merged
merged 5 commits into from
Sep 25, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/basic-store/src/pages/About/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { useEffect } from 'react';
import { Link, store as appStore } from 'ice';
import { Link, store as appStore } from 'ice';
import { store as pageStore } from 'ice/About';

const About = (props) => {
Expand Down
23 changes: 23 additions & 0 deletions examples/basic-store/src/pages/Detail/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import React from 'react';
import { store } from 'ice/Detail';

class Detail extends React.Component {
constructor(props) {
super(props);
console.log(this.props);
}

public render() {
const { default: detailStore } = this.props as any;
const [state, dispatcher] = detailStore;
return (
<>
<div>Detail Page</div>
<div>Title: {state.title}</div>
<button onClick={() => dispatcher.updateDetailTitle('test')} type="button">Change Title</button>
</>
);
}
}

export default store.withModel('default')(Detail);
26 changes: 26 additions & 0 deletions examples/basic-store/src/pages/Detail/model.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
const delay = (time) => new Promise((resolve) => setTimeout(() => resolve(), time));


export default {
state: {
title: 'detail'
},

reducers: {
update(prevState, payload) {
return {
...prevState,
...payload,
};
},
},

effects: (dispatch) => ({
async updateDetailTitle(title: string) {
await delay(1000);
dispatch.default.update({
title
});
},
}),
};
5 changes: 5 additions & 0 deletions examples/basic-store/src/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import Layout from '@/layouts/index';
import Home from '@/pages/Home';
import About from '@/pages/About';
import Detail from '@/pages/Detail';
import { NotFound } from '@/pages/NotFound';
import Index from '@/pages/Index';

Expand All @@ -25,6 +26,10 @@ export default [
path: '/about',
component: About
},
{
path: '/detail',
component: Detail
},
{
path: '/index',
component: Index
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-store/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "build-plugin-ice-store",
"version": "1.7.2",
"version": "1.7.3",
"description": "builtin `icestore` in icejs",
"author": "ice-admin@alibaba-inc.com",
"homepage": "",
Expand Down
23 changes: 20 additions & 3 deletions packages/plugin-store/src/generator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export default class Generator {
const pageComponentName = `Page${pageName}`;
const pageComponentRenderData = {
isRax: this.isRax,
pageComponentImport: `import ${pageComponentName} from '${pageComponentSourcePath}'` ,
pageComponentImport: `import ${pageComponentName} from '${pageComponentSourcePath}'`,
pageComponentExport: pageComponentName,
hasPageStore: false,
pageStoreImport: existedStoreFile ? `import store from '${pageStoreFile}'` : 'import store from \'./store\''
Expand All @@ -156,12 +156,26 @@ export default class Generator {
pageComponentRenderData.hasPageStore = true;
}

this.renderFile(pageComponentTemplatePath, pageComponentTargetPath , pageComponentRenderData);
this.renderFile(pageComponentTemplatePath, pageComponentTargetPath, pageComponentRenderData);
}

private renderPageIndex(params) {
const { pageName, pageModelsDir, pageModelFile, existedStoreFile } = params;
const pageIndexTemplatePath = path.join(__dirname, './template/pageIndex.ts.ejs');
const pageComponentTargetPath = path.join(this.targetPath, 'pages', pageName, 'index.ts');

const existStore = fse.pathExistsSync(pageModelsDir) || fse.pathExistsSync(pageModelFile) || existedStoreFile;
const pageComponentRenderData = {
pageImports: existStore ? 'import store from \'./store\'' : '',
pageExports: existStore ? ' store ' : ''
};

this.renderFile(pageIndexTemplatePath, pageComponentTargetPath, pageComponentRenderData);
}

private renderFile(templatePath: string, targetPath: string, extraData = {}) {
const templateContent = fse.readFileSync(templatePath, 'utf-8');
let content = ejs.render(templateContent, {...extraData});
let content = ejs.render(templateContent, { ...extraData });
try {
content = prettier.format(content, {
parser: 'typescript',
Expand Down Expand Up @@ -199,6 +213,9 @@ export default class Generator {

// generate .ice/pages/${pageName}/${pageName}.tsx
this.renderPageComponent(params);

// generate .ice/pages/${pageName}/index.ts
this.renderPageIndex(params);
});
}
}
3 changes: 2 additions & 1 deletion packages/plugin-store/src/template/pageComponent.tsx.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
<% } else { %>
import * as React from 'react';
<% } %>
<%- pageComponentImport %>

<% if(hasPageStore) { %>
<%- pageStoreImport %>
<% } %>

<%- pageComponentImport %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在这样有循环依赖问题。单独生成 PageName.tsx 文件,然后 index.ts 只负责导出 store

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.


const PageComponentName = <%= pageComponentExport %>;

<% if(hasPageStore) { %>
Expand Down
5 changes: 5 additions & 0 deletions packages/plugin-store/src/template/pageIndex.ts.ejs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<%- pageImports %>

export {
<%= pageExports %>
}