feat: support singleton input #1933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Abingcbc
commented
Nov 28, 2024
•
Abingcbc
commented
- 加载流水线时，对只能存在一个实例的input进行限制
- 对加载的配置顺序进行排序，保证先创建的配置，先加载流水线
Abingcbc
force-pushed
the
singleton_input
branch
from
c99d876
to
5c0d9c8
Compare
henryzhx8
requested changes
Nov 29, 2024
messixukejia
requested changes
Dec 4, 2024
| @@ -80,6 +80,22 @@ bool IsConfigEnabled(const string& name, const Json::Value& detail) { | |||
| return true; | |||
| } | |||
|
|
|||
| void GetAllInputTypes(const Json::Value& detail, std::vector<string>& inputTypes) { | |||
| { | ||
| "inputs": [ | ||
| { | ||
| "Type": "input_network_observer" |
There was a problem hiding this comment.
多input的行为是什么，也需要有用例覆盖
| @@ -238,10 +241,10 @@ bool PipelineConfig::Parse() { | |||
| } | |||
| } | |||
| // TODO: remove these special restrictions | |||
| if (hasFileInput && (*mDetail)["inputs"].size() > 1) { | |||
| if ((hasFileInput || !mSingletonInput.empty()) && (*mDetail)["inputs"].size() > 1) { | |||
There was a problem hiding this comment.
感觉还是把判断放上面吧。因为文件这个限制肯定是要去掉的。
可以跟笃敏再确认下
| private: | ||
| }; | ||
|
|
||
| void PipelineConfigWatcherUnittest::TestPushPipelineConfig() const { |
There was a problem hiding this comment.
需要给下测试用例设计，一些边界的组合需要考虑全面
| "skip current object")("config", config.mName)("inputType", config.mSingletonInput)); | ||
| return; | ||
| } | ||
| if (mPipelineManager->FindConfigByName(it->second->config.mName)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.