Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified implementation of Http requests #2858

Closed
chuntaojun opened this issue May 22, 2020 · 1 comment · Fixed by #2926
Closed

Unified implementation of Http requests #2858

chuntaojun opened this issue May 22, 2020 · 1 comment · Fixed by #2926
Assignees
@Maijh97
Labels
contribution welcome
Milestone
1.4.0

Comments

@chuntaojun
Copy link
Collaborator

Issue Description

Type: feature request

Describe what happened (or what feature you want)

background

  1. At present, the implementation of http requests in nacos is too disorderly, JDK, HttpClient, and Netty-HttpClient
  2. It is necessary to do a layer of abstract processing for httpclient in the nacos-common package, and install the specific httpclient implementation to avoid overcoupling the nacos project with a certain http implementation
    Ideas
  3. You can refer to the design of Spring's RestTemplate
  4. At present, it is only a simple abstraction in nacos-common http, which can be optimized and reconstructed

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?
@chuntaojun chuntaojun added this to the 1.3.0 milestone May 22, 2020
@Maijh97
Copy link
Collaborator

Maijh97 commented May 22, 2020

@i will solve it@

@Maijh97 Maijh97 mentioned this issue May 30, 2020
Merged
5 tasks
@KomachiSion KomachiSion modified the milestones: 1.3.0, 1.3.1 Jun 10, 2020
@yanlinly yanlinly modified the milestones: 1.3.1, 1.4.0 Jun 11, 2020
KomachiSion added a commit that referenced this issue Jun 12, 2020
@KomachiSion
Merge pull request #2926 from Maijh97/develop
81f9eff 
[ISSUE #2858] Unified implementation of Http requests
@KomachiSion KomachiSion mentioned this issue Jun 17, 2020
Closed
This was referenced Jun 22, 2020
Closed
Merged
@Maijh97 Maijh97 mentioned this issue Jul 2, 2020
Closed
5 tasks
This was referenced Jul 13, 2020
Closed
Closed
This was referenced Jul 21, 2020
Closed
Merged
KomachiSion pushed a commit that referenced this issue Jul 27, 2020
@Maijh97
[ISSUE #2858] Unified http client implementation, enhanced async requ…
5b76fd0 
…est callback interface (#3452)

* Enhanced callback interface for asynchronous requests

* change class name

* add license

* change class name

* comment change

* delete AbstractCallback
@KomachiSion KomachiSion mentioned this issue Aug 4, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maijh97 Maijh97

Labels
contribution welcome
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

[ISSUE #2858] Unified implementation of Http requests
4 participants
@yanlinly @chuntaojun @KomachiSion @Maijh97