[ISSUE #3140]nacos-client module replace http client #3142
Conversation
# Conflicts: # client/src/main/java/com/alibaba/nacos/client/naming/net/NamingProxy.java # common/src/main/java/com/alibaba/nacos/common/http/BaseHttpMethod.java # common/src/main/java/com/alibaba/nacos/common/http/HttpClientBeanHolder.java # common/src/main/java/com/alibaba/nacos/common/http/client/NacosRestTemplate.java # common/src/main/java/com/alibaba/nacos/common/http/handler/ResponseHandler.java
Maijh97
changed the title
Maijh97
changed the title
|
The nacos-client module http client has been replaced by NacosRestTemplate,please help to review this pr, thanks. @chuntaojun @KomachiSion |
| @@ -49,7 +49,7 @@ | |||
| * @author <a href="mailto:liaochuntao@live.com">liaochuntao</a> | |||
| */ | |||
| public enum BaseHttpMethod { | |||
|
|
|||
There was a problem hiding this comment.
Do not change the indent.
| @@ -34,21 +34,15 @@ | |||
| * @author mai.jh | |||
| */ | |||
| public final class HttpClientBeanHolder { | |||
|
|
|||
There was a problem hiding this comment.
do not change indent please
| @@ -78,14 +78,22 @@ | |||
| String contentType = headers.getValue(HttpHeaderConsts.CONTENT_TYPE); | |||
| InputStream body = response.getBody(); | |||
| T extractBody = null; | |||
| boolean typeToStr = String.class.toString().equals(type.toString()); | |||
There was a problem hiding this comment.
If the tmp variable is only used once, I suggest do not change.
| } | ||
| if (extractBody == null) { | ||
| if (!String.class.toString().equals(type.toString())) { | ||
| if (!typeToStr) { |
There was a problem hiding this comment.
If the tmp variable is only used once, I suggest do not change.
| * @return {@link HttpRestResult} | ||
| * @throws Exception ex | ||
| */ | ||
| public <T> HttpRestResult<T> exchangeFrom(String url, Header header, |
There was a problem hiding this comment.
What's the mean of From I read the method think it should be exchangeForm, is it?
| Header header = Header.newInstance(); | ||
| header.addParam(HttpHeaderConsts.USER_AGENT_HEADER, "Nacos-Server"); | ||
|
|
||
| HttpRestResult<String> result = nacosRestTemplate.putFrom(url, header, Query.EMPTY, new HashMap<>(), String.class); |
There was a problem hiding this comment.
What's the mean of From I read the method think it should be putFrom, is it?
I have adjusted the code.please help to review this pr again, thanks. @KomachiSion |
| @@ -59,14 +59,14 @@ protected HttpRequestBase createRequest(String url) { | |||
| return new HttpGet(url); | |||
| } | |||
| }, | |||
|
|
|||
| private static final AtomicBoolean ALREADY_SHUTDOWN = new AtomicBoolean(false); | ||
|
|
| */ | ||
| public interface HttpClientResponse extends Closeable { | ||
|
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
nacos-client module replace http client
Brief changelog
fix: #3140 refer: #2858, #3192
Unified use of httpclient
use
nacosRestTemplatereplacenacos-clientmodulehttpClientVerifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.